Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-18 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142548
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49750/
> ---
> 
> (Updated July 7, 2016, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17605
> https://issues.apache.org/jira/browse/AMBARI-17605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
> location of temporary table. 
> 
> In this patch : Now it will use query describe formatted for finding the 
> actual location of temporary table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
>  20b91f1 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
>  0171626 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
>  0da49c4 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  18da1ff 
> 
> Diff: https://reviews.apache.org/r/49750/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-18 Thread Ashwin Rajeev

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142540
---


Ship it!




Ship It!

- Ashwin Rajeev


On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49750/
> ---
> 
> (Updated July 7, 2016, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17605
> https://issues.apache.org/jira/browse/AMBARI-17605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
> location of temporary table. 
> 
> In this patch : Now it will use query describe formatted for finding the 
> actual location of temporary table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
>  20b91f1 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
>  0171626 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
>  0da49c4 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  18da1ff 
> 
> Diff: https://reviews.apache.org/r/49750/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-18 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142537
---


Ship it!




Ship It!

- Gaurav Nagar


On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49750/
> ---
> 
> (Updated July 7, 2016, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17605
> https://issues.apache.org/jira/browse/AMBARI-17605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
> location of temporary table. 
> 
> In this patch : Now it will use query describe formatted for finding the 
> actual location of temporary table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
>  20b91f1 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
>  0171626 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
>  0da49c4 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  18da1ff 
> 
> Diff: https://reviews.apache.org/r/49750/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-07 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17605
https://issues.apache.org/jira/browse/AMBARI-17605


Repository: ambari


Description
---

Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
location of temporary table. 

In this patch : Now it will use query describe formatted for finding the actual 
location of temporary table.


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
 20b91f1 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
 0171626 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
 0da49c4 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
 18da1ff 

Diff: https://reviews.apache.org/r/49750/diff/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore