Re: Review Request 49831: AMBARI-17562 - Adding single stack, extension and service should be removed from management pack support

2016-07-11 Thread Jayush Luniya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49831/#review141725
---


Ship it!




Ship It!

- Jayush Luniya


On July 8, 2016, 9:13 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49831/
> ---
> 
> (Updated July 8, 2016, 9:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17562
> https://issues.apache.org/jira/browse/AMBARI-17562
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This code is duplicated by the ability to add multiple stacks, extensions and 
> addon services. There is no reason to maintain both code paths.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 5acc92c 
>   ambari-server/src/test/python/TestMpacks.py 0995280 
>   
> ambari-server/src/test/python/mpacks/myservice-ambari-mpack-1.0.0.0/mpack.json
>  0af6949 
> 
> Diff: https://reviews.apache.org/r/49831/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> 
> No errors related to the mpack tests
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>



Review Request 49831: AMBARI-17562 - Adding single stack, extension and service should be removed from management pack support

2016-07-08 Thread Tim Thorpe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49831/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, 
and Sumit Mohanty.


Bugs: AMBARI-17562
https://issues.apache.org/jira/browse/AMBARI-17562


Repository: ambari


Description
---

This code is duplicated by the ability to add multiple stacks, extensions and 
addon services. There is no reason to maintain both code paths.


Diffs
-

  ambari-server/src/main/python/ambari_server/setupMpacks.py 5acc92c 
  ambari-server/src/test/python/TestMpacks.py 0995280 
  
ambari-server/src/test/python/mpacks/myservice-ambari-mpack-1.0.0.0/mpack.json 
0af6949 

Diff: https://reviews.apache.org/r/49831/diff/


Testing
---

mvn clean test -DskipSurefireTests

No errors related to the mpack tests


Thanks,

Tim Thorpe