Re: Review Request 50007: Hive Restart Failed During RU Due To Missing SQL JAR

2016-07-14 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50007/#review142223
---


Ship it!




Ship It!

- Nate Cole


On July 13, 2016, 6:05 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50007/
> ---
> 
> (Updated July 13, 2016, 6:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17697
> https://issues.apache.org/jira/browse/AMBARI-17697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> # Deploy HDP 2.3 with Hive
> # Register and install HDP 2.5.0.0-945
> # Perform RU to 2.5.0.0-945 version
> # After Hive Upgrades, Downgrade
> 
> {code}
> resource_management.core.exceptions.Fail: Execution of 'cp 
> --remove-destination /var/lib/ambari-agent/tmp/mysql-connector-java.jar 
> /usr/hdp/2.3.0.0-2557/hive2/lib/mysql-connector-java.jar' returned 1. cp: 
> cannot create regular file 
> '/usr/hdp/2.3.0.0-2557/hive2/lib/mysql-connector-java.jar': No such file or 
> directory
> {code}
> 
> I believe the problem is this line of code:
> {code}
> if check_stack_feature(StackFeature.HIVE_SERVER_INTERACTIVE, 
> stack_version_unformatted):
> {code}
> 
> On a downgrade from 2.5 to 2.3 {{version}} and {{current_version}} are 
> pointing to 2.3, but stack_version_unformatted is still 2.5. Because of this, 
> we initialize the hive2 variables which leads us to think that hive2 is the 
> target of copying the JDBC:
> 
> {code}
>   if name == 'metastore' or name == 'hiveserver2':
> if params.hive_jdbc_target is not None and not 
> os.path.exists(params.hive_jdbc_target):
>   jdbc_connector(params.hive_jdbc_target, params.hive_previous_jdbc_jar)
> if params.hive2_jdbc_target is not None and not 
> os.path.exists(params.hive2_jdbc_target):
>   jdbc_connector(params.hive2_jdbc_target, params.hive2_previous_jdbc_jar)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b148849 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hcat_client.py 54d3e84 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 77d6bdb 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 4909c77 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6c46267 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> a8b5421 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> f71bba9 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> 044598d 
> 
> Diff: https://reviews.apache.org/r/50007/diff/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:1018
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>



Review Request 50007: Hive Restart Failed During RU Due To Missing SQL JAR

2016-07-13 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50007/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
Cole.


Bugs: AMBARI-17697
https://issues.apache.org/jira/browse/AMBARI-17697


Repository: ambari


Description
---

# Deploy HDP 2.3 with Hive
# Register and install HDP 2.5.0.0-945
# Perform RU to 2.5.0.0-945 version
# After Hive Upgrades, Downgrade

{code}
resource_management.core.exceptions.Fail: Execution of 'cp --remove-destination 
/var/lib/ambari-agent/tmp/mysql-connector-java.jar 
/usr/hdp/2.3.0.0-2557/hive2/lib/mysql-connector-java.jar' returned 1. cp: 
cannot create regular file 
'/usr/hdp/2.3.0.0-2557/hive2/lib/mysql-connector-java.jar': No such file or 
directory
{code}

I believe the problem is this line of code:
{code}
if check_stack_feature(StackFeature.HIVE_SERVER_INTERACTIVE, 
stack_version_unformatted):
{code}

On a downgrade from 2.5 to 2.3 {{version}} and {{current_version}} are pointing 
to 2.3, but stack_version_unformatted is still 2.5. Because of this, we 
initialize the hive2 variables which leads us to think that hive2 is the target 
of copying the JDBC:

{code}
  if name == 'metastore' or name == 'hiveserver2':
if params.hive_jdbc_target is not None and not 
os.path.exists(params.hive_jdbc_target):
  jdbc_connector(params.hive_jdbc_target, params.hive_previous_jdbc_jar)
if params.hive2_jdbc_target is not None and not 
os.path.exists(params.hive2_jdbc_target):
  jdbc_connector(params.hive2_jdbc_target, params.hive2_previous_jdbc_jar)
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 571eebd 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 b148849 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hcat_client.py 54d3e84 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 77d6bdb 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
4909c77 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6c46267 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
a8b5421 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
f71bba9 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 044598d 

Diff: https://reviews.apache.org/r/50007/diff/


Testing
---

OK
--
Total run:1018
Total errors:0
Total failures:0
OK


Thanks,

Jonathan Hurley