Re: Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50167/#review142713 --- Ship it! Ship It! - Dmytro Sen On Июль 18, 2016, 11:59 п.п., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50167/ > --- > > (Updated Июль 18, 2016, 11:59 п.п.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17779 > https://issues.apache.org/jira/browse/AMBARI-17779 > > > Repository: ambari > > > Description > --- > > Following set of changes are being done for this patch. > 1. Fix bug in AMS that does not allow hbase normalizer config to be disabled > for AMS tables. > 2. Fix issue in default TopN behavior for point in time queries > 3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase > lib directories, during rpm assembly. > > > Diffs > - > > ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 > ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > dd1ae3f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 16ebcd9 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java > 7c6e7f4 > > Diff: https://reviews.apache.org/r/50167/diff/ > > > Testing > --- > > Unit tests pass. > Manual testing done. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50167/ --- (Updated July 18, 2016, 11:59 p.m.) Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17779 https://issues.apache.org/jira/browse/AMBARI-17779 Repository: ambari Description --- Following set of changes are being done for this patch. 1. Fix bug in AMS that does not allow hbase normalizer config to be disabled for AMS tables. 2. Fix issue in default TopN behavior for point in time queries 3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase lib directories, during rpm assembly. Diffs - ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java dd1ae3f ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 16ebcd9 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 7c6e7f4 Diff: https://reviews.apache.org/r/50167/diff/ Testing (updated) --- Unit tests pass. Manual testing done. Thanks, Aravindan Vijayan
Re: Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50167/#review142664 --- Ship it! Ship It! - Sid Wagle On July 18, 2016, 11:10 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50167/ > --- > > (Updated July 18, 2016, 11:10 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17779 > https://issues.apache.org/jira/browse/AMBARI-17779 > > > Repository: ambari > > > Description > --- > > Following set of changes are being done for this patch. > 1. Fix bug in AMS that does not allow hbase normalizer config to be disabled > for AMS tables. > 2. Fix issue in default TopN behavior for point in time queries > 3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase > lib directories, during rpm assembly. > > > Diffs > - > > ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 > ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > dd1ae3f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 16ebcd9 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java > 7c6e7f4 > > Diff: https://reviews.apache.org/r/50167/diff/ > > > Testing > --- > > Unit tests pass. > Manual testing of (2) and (3) done. > Manual testing of (1) pending. > > > Thanks, > > Aravindan Vijayan > >
Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50167/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17779 https://issues.apache.org/jira/browse/AMBARI-17779 Repository: ambari Description --- Following set of changes are being done for this patch. 1. Fix bug in AMS that does not allow hbase normalizer config to be disabled for AMS tables. 2. Fix issue in default TopN behavior for point in time queries 3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase lib directories, during rpm assembly. Diffs - ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java dd1ae3f ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 16ebcd9 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 7c6e7f4 Diff: https://reviews.apache.org/r/50167/diff/ Testing --- Unit tests pass. Manual testing of (2) and (3) done. Manual testing of (1) pending. Thanks, Aravindan Vijayan
