Re: Review Request 50169: Atlas hooks for Hive, Falcon, Storm missing atlas.jaas.KafkaClient.option.principal & atlas.jaas.KafkaClient.option.keytab

2016-07-19 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50169/#review142781
---


Ship it!




Ship It!

- Robert Levas


On July 19, 2016, 1:50 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50169/
> ---
> 
> (Updated July 19, 2016, 1:50 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jaimin Jetly, Robert Levas, 
> Nahappan Somasundaram, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17780
> https://issues.apache.org/jira/browse/AMBARI-17780
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In HDP 2.5, the following config files are missing two properties when the 
> cluster is Kerberized.
> 
> Files:
> hive-atlas-application.properties
> storm-atlas-application.properties
> falconm-atlas-application.properties
> 
> Properties:
> atlas.jaas.KafkaClient.option.principal
> atlas.jaas.KafkaClient.option.keytab
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  947d441 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  939e232 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  e4d2392 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params.py
>  f2d01fc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f8d588 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  5bca720 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  591e548 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 5a9f24c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 6081a04 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> b5ec1c9 
> 
> Diff: https://reviews.apache.org/r/50169/diff/
> 
> 
> Testing
> ---
> 
> Verified with HDP 2.5 and Kerberizing the cluster with Atlas, Storm, Hive, 
> Falcon, Sqoop
> 
> Python unit tests passed,
> Total run:1019
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Review Request 50169: Atlas hooks for Hive, Falcon, Storm missing atlas.jaas.KafkaClient.option.principal & atlas.jaas.KafkaClient.option.keytab

2016-07-18 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50169/
---

Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, and Sumit 
Mohanty.


Bugs: AMBARI-17780
https://issues.apache.org/jira/browse/AMBARI-17780


Repository: ambari


Description
---

In HDP 2.5, the following config files are missing two properties when the 
cluster is Kerberized.

Files:
hive-atlas-application.properties
storm-atlas-application.properties
falconm-atlas-application.properties

Properties:
atlas.jaas.KafkaClient.option.principal
atlas.jaas.KafkaClient.option.keytab


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 947d441 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 939e232 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 e4d2392 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params.py
 f2d01fc 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 6f8d588 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 5bca720 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 591e548 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
5a9f24c 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
6081a04 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
b5ec1c9 

Diff: https://reviews.apache.org/r/50169/diff/


Testing
---

Verified with HDP 2.5 and Kerberizing the cluster with Atlas, Storm, Hive, 
Falcon, Sqoop

Python unit tests passed,
Total run:1019
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez