Re: Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

2016-07-21 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50289/#review143112
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 21, 2016, 12:57 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50289/
> ---
> 
> (Updated July 21, 2016, 12:57 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17832
> https://issues.apache.org/jira/browse/AMBARI-17832
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Install HDP 2.4 with HDFS, ZK, MR, LogSearch, and Atlas (with requires either 
> internal or external HBASE)
> 
> Will fail because no HBASE was provided and it did not warn or show an error 
> about missing HBASE configs.
> 
> Deployment error:
> {code}
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 294, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'source 
> /etc/atlas/conf/atlas-env.sh ; 
> /usr/hdp/current/atlas-server/bin/atlas_start.py' returned 255. Exception: 
> ('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to 
> the hbase client conf dir', '/etc/hbase/conf')
> Traceback (most recent call last):
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 150, in 
> returncode = main()
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 93, in main
> raise Exception("Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir", hbase_conf_dir)
> Exception: ('Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir', '/etc/hbase/conf')
> {code}
> 
> UI did not prompt to select HBase when selecting Atlas.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 502d1a4 
> 
> Diff: https://reviews.apache.org/r/50289/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>



Re: Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

2016-07-21 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50289/#review143081
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 21, 2016, 12:57 п.п., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50289/
> ---
> 
> (Updated Июль 21, 2016, 12:57 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17832
> https://issues.apache.org/jira/browse/AMBARI-17832
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Install HDP 2.4 with HDFS, ZK, MR, LogSearch, and Atlas (with requires either 
> internal or external HBASE)
> 
> Will fail because no HBASE was provided and it did not warn or show an error 
> about missing HBASE configs.
> 
> Deployment error:
> {code}
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 294, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'source 
> /etc/atlas/conf/atlas-env.sh ; 
> /usr/hdp/current/atlas-server/bin/atlas_start.py' returned 255. Exception: 
> ('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to 
> the hbase client conf dir', '/etc/hbase/conf')
> Traceback (most recent call last):
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 150, in 
> returncode = main()
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 93, in main
> raise Exception("Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir", hbase_conf_dir)
> Exception: ('Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir', '/etc/hbase/conf')
> {code}
> 
> UI did not prompt to select HBase when selecting Atlas.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 502d1a4 
> 
> Diff: https://reviews.apache.org/r/50289/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>



Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

2016-07-21 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50289/
---

Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.


Bugs: AMBARI-17832
https://issues.apache.org/jira/browse/AMBARI-17832


Repository: ambari


Description
---

STR:
Install Ambari 2.4
Install HDP 2.4 with HDFS, ZK, MR, LogSearch, and Atlas (with requires either 
internal or external HBASE)

Will fail because no HBASE was provided and it did not warn or show an error 
about missing HBASE configs.

Deployment error:
{code}
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
294, in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'source 
/etc/atlas/conf/atlas-env.sh ; 
/usr/hdp/current/atlas-server/bin/atlas_start.py' returned 255. Exception: 
('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to the 
hbase client conf dir', '/etc/hbase/conf')
Traceback (most recent call last):
File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 150, in 
returncode = main()
File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 93, in main
raise Exception("Could not find hbase-site.xml in %s. Please set env var 
HBASE_CONF_DIR to the hbase client conf dir", hbase_conf_dir)
Exception: ('Could not find hbase-site.xml in %s. Please set env var 
HBASE_CONF_DIR to the hbase client conf dir', '/etc/hbase/conf')
{code}

UI did not prompt to select HBase when selecting Atlas.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
5e380d8 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 502d1a4 

Diff: https://reviews.apache.org/r/50289/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko