Re: Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

2016-07-21 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50306/#review143135
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On July 21, 2016, 7:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50306/
> ---
> 
> (Updated July 21, 2016, 7:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17841
> https://issues.apache.org/jira/browse/AMBARI-17841
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> # Deploy a service ad abort installation in the middle in a way such that 
> some of its slave host components remains in INSTALLED_FAILED state but no all
> # Try deleting service
> 
> *Expected Result:* UI should allow service deletion as API allows it in this 
> scenario
> *Actual Result:* UI shows a warning popup in green color and does not let 
> user delete a service. screenshot attached
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/client_component.js 3902227 
>   ambari-web/app/models/host_component.js 91642c9 
>   ambari-web/app/models/service.js c648e93 
>   ambari-web/test/models/service_test.js e527e1e 
> 
> Diff: https://reviews.apache.org/r/50306/diff/
> 
> 
> Testing
> ---
> 
> Verified that the patch fixes the issue on a cluster
> Verified that ambari-web unit tests passes with the patch
> 29219 tests complete (29 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

2016-07-21 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50306/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17841
https://issues.apache.org/jira/browse/AMBARI-17841


Repository: ambari


Description
---

*STR:*
# Deploy a service ad abort installation in the middle in a way such that some 
of its slave host components remains in INSTALLED_FAILED state but no all
# Try deleting service

*Expected Result:* UI should allow service deletion as API allows it in this 
scenario
*Actual Result:* UI shows a warning popup in green color and does not let user 
delete a service. screenshot attached


Diffs
-

  ambari-web/app/models/client_component.js 3902227 
  ambari-web/app/models/host_component.js 91642c9 
  ambari-web/app/models/service.js c648e93 
  ambari-web/test/models/service_test.js e527e1e 

Diff: https://reviews.apache.org/r/50306/diff/


Testing
---

Verified that the patch fixes the issue on a cluster
Verified that ambari-web unit tests passes with the patch
29219 tests complete (29 seconds)
154 tests pending


Thanks,

Jaimin Jetly