Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-11 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/#review145472
---


Ship it!





ambari-server/src/test/python/common-services/HAWQ/hawq_base_test_case.py (line 
21)


https://www.python.org/dev/peps/pep-0008/#imports



ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
 (line 21)


https://www.python.org/dev/peps/pep-0008/#imports


- Matt


On Aug. 10, 2016, 5:43 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50965/
> ---
> 
> (Updated Aug. 10, 2016, 5:43 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Matt.
> 
> 
> Bugs: AMBARI-18110
> https://issues.apache.org/jira/browse/AMBARI-18110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari build jobs are not running the unit tests for HAWQ.
> HAWQ (and PXF) unit tests in the new common-services directory under test is 
> being ignored during mvn's test phase.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  529c492 
>   ambari-server/src/test/python/common-services/HAWQ/hawq_base_test_case.py 
> PRE-CREATION 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
>  b2e1d4d 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
>  4066e29 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
> a44cad1 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 
> 62d54cf 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
> 48203ca 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
> 8674549 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> e0f1c43 
>   ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
> ee187e2 
>   ambari-server/src/test/python/common-services/PXF/test_pxf.py c291261 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 8b2a4ba 
>   ambari-server/src/test/python/unitTests.py b010804 
> 
> Diff: https://reviews.apache.org/r/50965/diff/
> 
> 
> Testing
> ---
> 
> ```
> Running tests for stack:None service:HAWQ
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-10 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/
---

(Updated Aug. 11, 2016, 12:43 a.m.)


Review request for Ambari, Alexander Denissov and Matt.


Bugs: AMBARI-18110
https://issues.apache.org/jira/browse/AMBARI-18110


Repository: ambari


Description
---

Ambari build jobs are not running the unit tests for HAWQ.
HAWQ (and PXF) unit tests in the new common-services directory under test is 
being ignored during mvn's test phase.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 529c492 
  ambari-server/src/test/python/common-services/HAWQ/hawq_base_test_case.py 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
 b2e1d4d 
  
ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
 4066e29 
  ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
a44cad1 
  ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 62d54cf 
  ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
48203ca 
  ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
8674549 
  ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
e0f1c43 
  ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
ee187e2 
  ambari-server/src/test/python/common-services/PXF/test_pxf.py c291261 
  ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
8b2a4ba 
  ambari-server/src/test/python/unitTests.py b010804 

Diff: https://reviews.apache.org/r/50965/diff/


Testing
---

```
Running tests for stack:None service:HAWQ
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 
/Users/ljain/dev/pivotal/ambari/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts
2016-08-10 13:20:33,060 - Removing HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-08-10 13:20:33,063 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-08-10 13:20:33,067 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-08-10 13:20:33,074 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-10 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/#review145407
---


Ship it!




Looks good, very useful refactoring. Please consider a few suggestions for 
naming.

- Alexander Denissov


On Aug. 10, 2016, 8:30 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50965/
> ---
> 
> (Updated Aug. 10, 2016, 8:30 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Matt.
> 
> 
> Bugs: AMBARI-18110
> https://issues.apache.org/jira/browse/AMBARI-18110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari build jobs are not running the unit tests for HAWQ.
> HAWQ (and PXF) unit tests in the new common-services directory under test is 
> being ignored during mvn's test phase.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  529c492 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
>  b2e1d4d 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
>  4066e29 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
> a44cad1 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py 
> PRE-CREATION 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 
> 62d54cf 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
> 48203ca 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
> 8674549 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> e0f1c43 
>   ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
> ee187e2 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 8b2a4ba 
>   ambari-server/src/test/python/unitTests.py b010804 
> 
> Diff: https://reviews.apache.org/r/50965/diff/
> 
> 
> Testing
> ---
> 
> ```
> Running tests for stack:None service:HAWQ
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 
> /Users/ljain/dev/pivotal/ambari/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts
> 2016-08-10 13:20:33,060 - Removing HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-08-10 13:20:33,063 - HAWQ 
> Standby Master Re-Sync

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-10 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/#review145405
---




ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
 (line 35)


probably do not need this here



ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py (line 25)


if this is a base class for HAWQ tests, maybe call it HAWQTestCase to 
denote that this is not a test class by itself ?



ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py (line 27)


this is where packages for HAWQ are, so COMMON_SERVICES_PACKAGE_DIR is a 
bit too general name for HAWQ specific directory



ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
(line 28)


PXF_ALERTS_DIR_PATH would be a better name


- Alexander Denissov


On Aug. 10, 2016, 8:30 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50965/
> ---
> 
> (Updated Aug. 10, 2016, 8:30 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Matt.
> 
> 
> Bugs: AMBARI-18110
> https://issues.apache.org/jira/browse/AMBARI-18110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari build jobs are not running the unit tests for HAWQ.
> HAWQ (and PXF) unit tests in the new common-services directory under test is 
> being ignored during mvn's test phase.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  529c492 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
>  b2e1d4d 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
>  4066e29 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
> a44cad1 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py 
> PRE-CREATION 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 
> 62d54cf 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
> 48203ca 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
> 8674549 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> e0f1c43 
>   ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
> ee187e2 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 8b2a4ba 
>   ambari-server/src/test/python/unitTests.py b010804 
> 
> Diff: https://reviews.apache.org/r/50965/diff/
> 
> 
> Testing
> ---
> 
> ```
> Running tests for stack:None service:HAWQ
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
>