Re: Review Request 51255: File View throws IllegalArguementException post Ambari 2.4.0.0 upgrade

2016-08-20 Thread Rohit Choudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51255/#review146238
---


Ship it!




Ship It!

- Rohit Choudhary


On Aug. 20, 2016, 6:33 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51255/
> ---
> 
> (Updated Aug. 20, 2016, 6:33 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18218
> https://issues.apache.org/jira/browse/AMBARI-18218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added null check before adding property.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  1c17e6a 
> 
> Diff: https://reviews.apache.org/r/51255/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>



Re: Review Request 51255: File View throws IllegalArguementException post Ambari 2.4.0.0 upgrade

2016-08-20 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51255/#review146233
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Aug. 20, 2016, 6:33 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51255/
> ---
> 
> (Updated Aug. 20, 2016, 6:33 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18218
> https://issues.apache.org/jira/browse/AMBARI-18218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added null check before adding property.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  1c17e6a 
> 
> Diff: https://reviews.apache.org/r/51255/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>