Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-11-10 Thread yao lei
> On 十一月 10, 2016, 3:02 p.m., Jonathan Hurley wrote: > > What's the state of this review? Has it been abandoned? If so, can we close > > it? jhurley,thanks for your attention. There seem not have more feedbacks about this review request. If you are sure this funciton is repeated in new

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/#review155589 --- What's the state of this review? Has it been abandoned? If so,

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread yao lei
> On 十月 12, 2016, 8:15 p.m., Xi Wang wrote: > > This will > > not impact the new "create alert wizard" because this is part of alert > > notifications management. Thanks for your comment. But I wonder whether I need to mark this jira as duplicatie if some relevent jiras have existed - yao

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread yao lei
> On 十月 12, 2016, 1:48 p.m., Jonathan Hurley wrote: > > I can't really comment on the front-end work since that's not an area I'm > > familiar with. However, I do believe there are Jiras scoping a new "wizard" > > workflow for alerts in Ambari 3.0 which this may impact. Thanks for your

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/#review152301 --- I can't really comment on the front-end work since that's not an

Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-09-22 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/ --- Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.