Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153414 --- Ship it! Ship It! - Jonathan Hurley On Oct. 18, 2016, 2:17

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153397 --- Ship it! Ship It! - Laszlo Puskas On Oct. 18, 2016, 6:17

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153396 --- Ship it! Ship It! - Sebastian Toader On Oct. 18, 2016, 8:17

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-18 Thread Sandor Magyari
> On Oct. 17, 2016, 2:36 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 3074-3076 > > > > > > Need a default-if-not-null here

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-18 Thread Sandor Magyari
> On Oct. 17, 2016, 2:19 p.m., Robert Levas wrote: > > Has this been tested using both models while enabling Kerberos? I've tested BP deployment of a secure cluster and Enable/Disable Kerberos, also Upgrade. Since this DEPENDENCY_ORDER execution applies only for requests marked with property

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-18 Thread Sandor Magyari
> On Oct. 17, 2016, 9:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java, > > lines 874-875 > > > > > > Why check both here? Isn't it enough

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-17 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review152962 ---

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-17 Thread Nate Cole
> On Oct. 14, 2016, 10:40 a.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 359 > > > > > > This could be an 'int' column and the values stored in it mapped to he

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review152841 --- Fix it, then Ship it! Has this been tested using both models

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review152833 --- Ship it! Ship It! - Sebastian Toader On Oct. 16, 2016,

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-16 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/ --- (Updated Oct. 16, 2016, 8:33 a.m.) Review request for Ambari, Alejandro

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review152677 --- ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-13 Thread Sandor Magyari
> On Oct. 11, 2016, 6:37 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java, > > line 410 > > > > > > Does this only affect fresh install

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-13 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/ --- (Updated Oct. 13, 2016, 3:50 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review152173 --- Overall a really good improvement to optimize the install/start

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review152166 ---

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-11 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/ --- (Updated Oct. 11, 2016, 2:41 p.m.) Review request for Ambari, Alejandro