Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/#review155881
---


Ship it!




Ship It!

- Sid Wagle


On Nov. 15, 2016, 1:57 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53597/
> ---
> 
> (Updated Nov. 15, 2016, 1:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-18829
> https://issues.apache.org/jira/browse/AMBARI-18829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow Ambari to manage Kafka's Custom JAAS Config.
> Move the existing j2 templates (kafka_jaas.conf.j2 and 
> kafka_client_jaas.conf.j2) into config properties.
> 
> I intentionally left the j2 templates and logic to fall back to j2 template 
> for now. They will be removed later.
> 
> Thanks Alejandro for pointing out the earlier patch being too large - I think 
> I diffed against the wrong branch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> 8630c87 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  6b4579c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  6fe438d 
> 
> Diff: https://reviews.apache.org/r/53597/diff/
> 
> 
> Testing
> ---
> 
> Manually ran unit tests on dev machine.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/#review155880
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Nov. 15, 2016, 1:57 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53597/
> ---
> 
> (Updated Nov. 15, 2016, 1:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-18829
> https://issues.apache.org/jira/browse/AMBARI-18829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow Ambari to manage Kafka's Custom JAAS Config.
> Move the existing j2 templates (kafka_jaas.conf.j2 and 
> kafka_client_jaas.conf.j2) into config properties.
> 
> I intentionally left the j2 templates and logic to fall back to j2 template 
> for now. They will be removed later.
> 
> Thanks Alejandro for pointing out the earlier patch being too large - I think 
> I diffed against the wrong branch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> 8630c87 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  6b4579c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  6fe438d 
> 
> Diff: https://reviews.apache.org/r/53597/diff/
> 
> 
> Testing
> ---
> 
> Manually ran unit tests on dev machine.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/
---

(Updated Nov. 15, 2016, 1:57 a.m.)


Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and Sid 
Wagle.


Bugs: AMBARI-18829
https://issues.apache.org/jira/browse/AMBARI-18829


Repository: ambari


Description
---

Allow Ambari to manage Kafka's Custom JAAS Config.
Move the existing j2 templates (kafka_jaas.conf.j2 and 
kafka_client_jaas.conf.j2) into config properties.

I intentionally left the j2 templates and logic to fall back to j2 template for 
now. They will be removed later.

Thanks Alejandro for pointing out the earlier patch being too large - I think I 
diffed against the wrong branch.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
8630c87 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
 6b4579c 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 6fe438d 

Diff: https://reviews.apache.org/r/53597/diff/


Testing
---

Manually ran unit tests on dev machine.


Thanks,

Sumit Mohanty

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/#review155875
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
 (line 34)


we don't need client section here for kafka_client_jaas


- Sriharsha Chintalapani


On Nov. 9, 2016, 6:22 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53597/
> ---
> 
> (Updated Nov. 9, 2016, 6:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-18829
> https://issues.apache.org/jira/browse/AMBARI-18829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow Ambari to manage Kafka's Custom JAAS Config.
> Move the existing j2 templates (kafka_jaas.conf.j2 and 
> kafka_client_jaas.conf.j2) into config properties.
> 
> I intentionally left the j2 templates and logic to fall back to j2 template 
> for now. They will be removed later.
> 
> Thanks Alejandro for pointing out the earlier patch being too large - I think 
> I diffed against the wrong branch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> 8630c87 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  ac7b0ae 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  6fe438d 
> 
> Diff: https://reviews.apache.org/r/53597/diff/
> 
> 
> Testing
> ---
> 
> Manually ran unit tests on dev machine.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/
---

Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and Sid 
Wagle.


Bugs: AMBARI-18829
https://issues.apache.org/jira/browse/AMBARI-18829


Repository: ambari


Description
---

Allow Ambari to manage Kafka's Custom JAAS Config.
Move the existing j2 templates (kafka_jaas.conf.j2 and 
kafka_client_jaas.conf.j2) into config properties.

I intentionally left the j2 templates and logic to fall back to j2 template for 
now. They will be removed later.

Thanks Alejandro for pointing out the earlier patch being too large - I think I 
diffed against the wrong branch.


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
8630c87 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
 ac7b0ae 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 6fe438d 

Diff: https://reviews.apache.org/r/53597/diff/


Testing
---

Manually ran unit tests on dev machine.


Thanks,

Sumit Mohanty