Re: Review Request 54989: HOU pre-checks indicate HA as a requirement

2016-12-23 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/#review160085
---


Ship it!




Ship It!

- Robert Levas


On Dec. 22, 2016, 3:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54989/
> ---
> 
> (Updated Dec. 22, 2016, 3:03 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19285
> https://issues.apache.org/jira/browse/AMBARI-19285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Host Ordered Upgrades do not require the cluster services to be installed in 
> HA mode. However, when executing:
> 
> {code}
> GET 
> api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
> {code}
> 
> HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
> running and failing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  3fc8650 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  45497b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  18fb2ad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  455a92d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  dd1385b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  11d6676 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> b75e923 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  6289ff5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  5e44c7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
>  88d9de6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
>  1f1980f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  eaedd3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  620c651 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  52546d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
>  a77ad9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  5e2db33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  b77e1d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  18a5bde 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d4c7894 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
>  90eea97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  3ed7a27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 9e43560 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
>  b770dd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
>  050d43e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  64c79a8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  2bcd482 
> 
> Diff: https://reviews.apache.org/r/54989/diff/
> 
> 
> Testing
> ---
> 
> Results :
> 
> Tests run: 4813, Failures: 0, Errors: 0, Skipped: 37
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:15 min
> [INFO] Finished at: 2016-12-22T15:00:07-05:00
> [INFO] Final Memory: 59M/678M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 54989: HOU pre-checks indicate HA as a requirement

2016-12-23 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/#review160073
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Dec. 22, 2016, 10:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54989/
> ---
> 
> (Updated Dec. 22, 2016, 10:03 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19285
> https://issues.apache.org/jira/browse/AMBARI-19285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Host Ordered Upgrades do not require the cluster services to be installed in 
> HA mode. However, when executing:
> 
> {code}
> GET 
> api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
> {code}
> 
> HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
> running and failing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  3fc8650 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  45497b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  18fb2ad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  455a92d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  dd1385b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  11d6676 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> b75e923 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  6289ff5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  5e44c7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
>  88d9de6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
>  1f1980f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  eaedd3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  620c651 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  52546d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
>  a77ad9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  5e2db33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  b77e1d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  18a5bde 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d4c7894 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
>  90eea97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  3ed7a27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 9e43560 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
>  b770dd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
>  050d43e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  64c79a8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  2bcd482 
> 
> Diff: https://reviews.apache.org/r/54989/diff/
> 
> 
> Testing
> ---
> 
> Results :
> 
> Tests run: 4813, Failures: 0, Errors: 0, Skipped: 37
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:15 min
> [INFO] Finished at: 2016-12-22T15:00:07-05:00
> [INFO] Final Memory: 59M/678M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 54989: HOU pre-checks indicate HA as a requirement

2016-12-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/
---

(Updated Dec. 22, 2016, 3:03 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19285
https://issues.apache.org/jira/browse/AMBARI-19285


Repository: ambari


Description
---

Host Ordered Upgrades do not require the cluster services to be installed in HA 
mode. However, when executing:

{code}
GET 
api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
{code}

HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
running and failing.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 3fc8650 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 45497b5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
 18fb2ad 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 455a92d 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
 dd1385b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
 11d6676 
  ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
b75e923 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
 6289ff5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
 5e44c7c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
 88d9de6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
 1f1980f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 eaedd3f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 620c651 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 52546d2 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
 a77ad9f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 5e2db33 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 b77e1d5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
 18a5bde 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 d4c7894 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
 90eea97 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
 3ed7a27 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
9e43560 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
 b770dd5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
 050d43e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
 64c79a8 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 2bcd482 

Diff: https://reviews.apache.org/r/54989/diff/


Testing (updated)
---

Results :

Tests run: 4813, Failures: 0, Errors: 0, Skipped: 37
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 28:15 min
[INFO] Finished at: 2016-12-22T15:00:07-05:00
[INFO] Final Memory: 59M/678M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 54989: HOU pre-checks indicate HA as a requirement

2016-12-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/
---

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19285
https://issues.apache.org/jira/browse/AMBARI-19285


Repository: ambari


Description
---

Host Ordered Upgrades do not require the cluster services to be installed in HA 
mode. However, when executing:

{code}
GET 
api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
{code}

HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
running and failing.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 3fc8650 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 45497b5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
 18fb2ad 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 455a92d 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
 dd1385b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
 11d6676 
  ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
b75e923 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
 6289ff5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
 5e44c7c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
 88d9de6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
 1f1980f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 eaedd3f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 620c651 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 52546d2 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
 a77ad9f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 5e2db33 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 b77e1d5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
 18a5bde 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 d4c7894 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
 90eea97 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
 3ed7a27 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
9e43560 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
 b770dd5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
 050d43e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
 64c79a8 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 2bcd482 

Diff: https://reviews.apache.org/r/54989/diff/


Testing
---

PENDING


Thanks,

Jonathan Hurley