Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55848/#review163121 --- Ship it! Ship It! - Tim Thorpe On Jan. 25, 2017, 9:36 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55848/ > --- > > (Updated Jan. 25, 2017, 9:36 p.m.) > > > Review request for Ambari, Jayush Luniya and Tim Thorpe. > > > Bugs: AMBARI-19630 > https://issues.apache.org/jira/browse/AMBARI-19630 > > > Repository: ambari > > > Description > --- > > Ambari current requires stack version ( used in the repo) as x.x.x.x-, > Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py > 7274a59 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > 615a0cd > ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 > > Diff: https://reviews.apache.org/r/55848/diff/ > > > Testing > --- > > unit tests > build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then > upgrade again, at the Finalize step verify the hostcomponentstate table has > 2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous > "IN_PROGESS". then be able to click the finalize and finalize the upgrade. > > > Thanks, > > Di Li > >
Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55848/ --- (Updated Jan. 25, 2017, 9:36 p.m.) Review request for Ambari, Jayush Luniya and Tim Thorpe. Bugs: AMBARI-19630 https://issues.apache.org/jira/browse/AMBARI-19630 Repository: ambari Description --- Ambari current requires stack version ( used in the repo) as x.x.x.x-, Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 7274a59 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py 615a0cd ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 Diff: https://reviews.apache.org/r/55848/diff/ Testing --- unit tests build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then upgrade again, at the Finalize step verify the hostcomponentstate table has 2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous "IN_PROGESS". then be able to click the finalize and finalize the upgrade. Thanks, Di Li
Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55848/#review162991 --- Ship it! Ship It! - Jayush Luniya On Jan. 23, 2017, 4:51 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55848/ > --- > > (Updated Jan. 23, 2017, 4:51 p.m.) > > > Review request for Ambari, Jayush Luniya and Tim Thorpe. > > > Bugs: AMBARI-19630 > https://issues.apache.org/jira/browse/AMBARI-19630 > > > Repository: ambari > > > Description > --- > > Ambari current requires stack version ( used in the repo) as x.x.x.x-, > Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py > 7274a59 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > 615a0cd > ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 > > Diff: https://reviews.apache.org/r/55848/diff/ > > > Testing > --- > > unit tests > build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then > upgrade again, at the Finalize step verify the hostcomponentstate table has > 2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous > "IN_PROGESS". then be able to click the finalize and finalize the upgrade. > > > Thanks, > > Di Li > >
Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55848/#review162654 --- Ship it! Ship It! - Tim Thorpe On Jan. 23, 2017, 4:51 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55848/ > --- > > (Updated Jan. 23, 2017, 4:51 p.m.) > > > Review request for Ambari, Jayush Luniya and Tim Thorpe. > > > Bugs: AMBARI-19630 > https://issues.apache.org/jira/browse/AMBARI-19630 > > > Repository: ambari > > > Description > --- > > Ambari current requires stack version ( used in the repo) as x.x.x.x-, > Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py > 7274a59 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > 615a0cd > ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 > > Diff: https://reviews.apache.org/r/55848/diff/ > > > Testing > --- > > unit tests > build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then > upgrade again, at the Finalize step verify the hostcomponentstate table has > 2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous > "IN_PROGESS". then be able to click the finalize and finalize the upgrade. > > > Thanks, > > Di Li > >
Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55848/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19630 https://issues.apache.org/jira/browse/AMBARI-19630 Repository: ambari Description --- Ambari current requires stack version ( used in the repo) as x.x.x.x-, Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x Diffs - ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 7274a59 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py 615a0cd ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 Diff: https://reviews.apache.org/r/55848/diff/ Testing --- unit tests build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then upgrade again, at the Finalize step verify the hostcomponentstate table has 2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous "IN_PROGESS". then be able to click the finalize and finalize the upgrade. Thanks, Di Li
