Re: Review Request 55850: Confirmation for adding host component from service summary page should be displayed once

2017-01-23 Thread Aleksandr Kovalenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55850/#review162660
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 23, 2017, 5:42 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55850/
> ---
> 
> (Updated Янв. 23, 2017, 5:42 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19678
> https://issues.apache.org/jira/browse/AMBARI-19678
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While adding component to host via Service Actions menu on service summary 
> page, two confirmation popups are displayed: the first one with host 
> selection and the second one with configs changes. Confirmation should be 
> displayed once.
> The above is correct for Hive Metastore, Ranger KMS Server and Nimbus. Adding 
> any other component from service summary doesn't result in displaying 
> properties to be updated.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/host/details.js 1fcc14d 
>   ambari-web/app/controllers/main/service/item.js 3a60137 
>   ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
> ed8445e 
>   ambari-web/app/templates/main/service/add_host_popup.hbs e5f2c99 
>   ambari-web/test/controllers/main/host/details_test.js ff5887c 
> 
> Diff: https://reviews.apache.org/r/55850/diff/
> 
> 
> Testing
> ---
> 
> 20321 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>



Review Request 55850: Confirmation for adding host component from service summary page should be displayed once

2017-01-23 Thread Andriy Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55850/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19678
https://issues.apache.org/jira/browse/AMBARI-19678


Repository: ambari


Description
---

While adding component to host via Service Actions menu on service summary 
page, two confirmation popups are displayed: the first one with host selection 
and the second one with configs changes. Confirmation should be displayed once.
The above is correct for Hive Metastore, Ranger KMS Server and Nimbus. Adding 
any other component from service summary doesn't result in displaying 
properties to be updated.


Diffs
-

  ambari-web/app/controllers/main/host/details.js 1fcc14d 
  ambari-web/app/controllers/main/service/item.js 3a60137 
  ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
ed8445e 
  ambari-web/app/templates/main/service/add_host_popup.hbs e5f2c99 
  ambari-web/test/controllers/main/host/details_test.js ff5887c 

Diff: https://reviews.apache.org/r/55850/diff/


Testing
---

20321 passing (21s)
  153 pending


Thanks,

Andriy Babiichuk