Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/#review163629 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 30, 2017, 4:56 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56078/ > --- > > (Updated Jan. 30, 2017, 4:56 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19523 > https://issues.apache.org/jira/browse/AMBARI-19523 > > > Repository: ambari > > > Description > --- > > Changed ivy-codemirror to custom component query-editor. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs > cbbcdd0 > > Diff: https://reviews.apache.org/r/56078/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/#review163529 --- Ship it! Ship It! - Gaurav Nagar On Jan. 30, 2017, 4:56 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56078/ > --- > > (Updated Jan. 30, 2017, 4:56 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19523 > https://issues.apache.org/jira/browse/AMBARI-19523 > > > Repository: ambari > > > Description > --- > > Changed ivy-codemirror to custom component query-editor. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs > cbbcdd0 > > Diff: https://reviews.apache.org/r/56078/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/ --- (Updated Jan. 30, 2017, 4:56 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary. Bugs: AMBARI-19523 https://issues.apache.org/jira/browse/AMBARI-19523 Repository: ambari Description --- Changed ivy-codemirror to custom component query-editor. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs cbbcdd0 Diff: https://reviews.apache.org/r/56078/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/#review163527 --- Ship it! Ship It! - Gaurav Nagar On Jan. 30, 2017, 4:12 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56078/ > --- > > (Updated Jan. 30, 2017, 4:12 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19523 > https://issues.apache.org/jira/browse/AMBARI-19523 > > > Repository: ambari > > > Description > --- > > Changed ivy-codemirror to custom component query-editor. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 4fe6f43 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5cdc9b3 > > Diff: https://reviews.apache.org/r/56078/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/ --- (Updated Jan. 30, 2017, 4:12 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary. Bugs: AMBARI-19523 https://issues.apache.org/jira/browse/AMBARI-19523 Repository: ambari Description --- Changed ivy-codemirror to custom component query-editor. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4fe6f43 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56078/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56078/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary. Bugs: AMBARI-19523 https://issues.apache.org/jira/browse/AMBARI-19523 Repository: ambari Description --- Changed ivy-codemirror to custom component query-editor. Diffs - contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs cbbcdd0 Diff: https://reviews.apache.org/r/56078/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
