Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/#review164853
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56443/
> ---
> 
> (Updated Feb. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19922
> https://issues.apache.org/jira/browse/AMBARI-19922
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding CSS class to deal such isssues.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  291def6 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
>  4fbd86b 
>   contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
> 0ab6cfd 
> 
> Diff: https://reviews.apache.org/r/56443/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/#review164847
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56443/
> ---
> 
> (Updated Feb. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19922
> https://issues.apache.org/jira/browse/AMBARI-19922
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding CSS class to deal such isssues.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  291def6 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
>  4fbd86b 
>   contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
> 0ab6cfd 
> 
> Diff: https://reviews.apache.org/r/56443/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/#review164705
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56443/
> ---
> 
> (Updated Feb. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19922
> https://issues.apache.org/jira/browse/AMBARI-19922
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding CSS class to deal such isssues.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  291def6 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
>  4fbd86b 
>   contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
> 0ab6cfd 
> 
> Diff: https://reviews.apache.org/r/56443/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

(Updated Feb. 8, 2017, 4:22 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description (updated)
---

Adding CSS class to deal such isssues.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha



Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

(Updated Feb. 8, 2017, 4:22 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description
---

Adding a helper to deal such isssues.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha



Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

(Updated Feb. 8, 2017, 1:11 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description
---

Adding a helper to deal such isssues.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/helpers/truncate-text.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha



Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description
---

Adding a helper to deal such isssues.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/helpers/truncate-text.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha