Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
> On March 9, 2017, 7:51 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you...can you please help in pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168506 --- On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168506 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168488 --- Ship it! Ship It! - Sangeeta Ravindran On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168483 --- Ship it! Ship It! - Di Li On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/ --- (Updated March 7, 2017, 1:02 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20333 https://issues.apache.org/jira/browse/AMBARI-20333 Repository: ambari Description --- According to yarn documentation, "yarn.scheduler.capacity..user-limit-factor" should be a float: https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html Hence the user should be allowed to enter decimal values for 'User limit factor' Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8eb06c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 69f5b3b Diff: https://reviews.apache.org/r/57346/diff/2/ Changes: https://reviews.apache.org/r/57346/diff/1-2/ Testing --- Tested manually File Attachments screenshot-1.png https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png Thanks, Anita Jebaraj
Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20333 https://issues.apache.org/jira/browse/AMBARI-20333 Repository: ambari Description --- According to yarn documentation, "yarn.scheduler.capacity..user-limit-factor" should be a float: https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html Hence the user should be allowed to enter decimal values for 'User limit factor' Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8eb06c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 69f5b3b Diff: https://reviews.apache.org/r/57346/diff/1/ Testing --- Tested manually File Attachments screenshot-1.png https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png Thanks, Anita Jebaraj
