Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/#review168600 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 10, 2017, 11:44 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57505/ > --- > > (Updated March 10, 2017, 11:44 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20360 > https://issues.apache.org/jira/browse/AMBARI-20360 > > > Repository: ambari > > > Description > --- > > Added error message to show if workflow xml doesn't contain workflow-app tag, > similarly coordinator-app tag for coordinator xml and bundle-app tag for > bundle xml. And also added the check for maximum number of nodes to render > and shown the error message if it exceeds maximum. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e94d51a > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c87ea99 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js > fdb4f5e > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 37992be > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js > b3eed4b > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > 12d923c > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > a076e3e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 3cab194 > > > Diff: https://reviews.apache.org/r/57505/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/#review168599 --- Ship it! Ship It! - belliraj hb On March 10, 2017, 11:44 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57505/ > --- > > (Updated March 10, 2017, 11:44 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20360 > https://issues.apache.org/jira/browse/AMBARI-20360 > > > Repository: ambari > > > Description > --- > > Added error message to show if workflow xml doesn't contain workflow-app tag, > similarly coordinator-app tag for coordinator xml and bundle-app tag for > bundle xml. And also added the check for maximum number of nodes to render > and shown the error message if it exceeds maximum. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e94d51a > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c87ea99 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js > fdb4f5e > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 37992be > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js > b3eed4b > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > 12d923c > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > a076e3e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 3cab194 > > > Diff: https://reviews.apache.org/r/57505/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20360 https://issues.apache.org/jira/browse/AMBARI-20360 Repository: ambari Description --- Added error message to show if workflow xml doesn't contain workflow-app tag, similarly coordinator-app tag for coordinator xml and bundle-app tag for bundle xml. And also added the check for maximum number of nodes to render and shown the error message if it exceeds maximum. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e94d51a contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js c87ea99 contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js fdb4f5e contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 37992be contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js b3eed4b contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 12d923c contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js a076e3e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 3cab194 Diff: https://reviews.apache.org/r/57505/diff/1/ Testing --- Manual Thanks, Madhan Reddy
