Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-04-12 Thread Anita Jebaraj 


> On April 12, 2017, 11:31 a.m., DIPAYAN BHOWMICK wrote:
> > Ship It!

Thank you for reviewing, can you please help in pushing the changes?


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review171710
---


On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated April 5, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-04-12 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review171710
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated April 5, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-27 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review170197
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
Lines 260 (patched)


Please include Jaimin Jetly and Richard Zhang in the code review.


- Alejandro Fernandez


On March 21, 2017, 5:15 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 21, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Anita Jebaraj 


> On March 21, 2017, 4:54 p.m., Alejandro Fernandez wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
> > Line 260 (original), 260 (patched)
> > 
> >
> > Good practice to always use braces.

I have fixed it in the updated patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169577
---


On March 21, 2017, 5:15 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 21, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Anita Jebaraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/
---

(Updated March 21, 2017, 5:15 p.m.)


Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
Ravindran.


Bugs: AMBARI-20334
https://issues.apache.org/jira/browse/AMBARI-20334


Repository: ambari


Description
---

capacity field in yarn queue manager should allow entering decimal numbers upto 
2 places,

currently the field allows entering values like

1.2.3
12...
1 2.3


Diffs (updated)
-

  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
 b6c419a 


Diff: https://reviews.apache.org/r/57709/diff/2/

Changes: https://reviews.apache.org/r/57709/diff/1-2/


Testing
---

Tested manually


Thanks,

Anita Jebaraj

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Sangeeta Ravindran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169575
---


Ship it!




Ship It!

- Sangeeta Ravindran


On March 16, 2017, 10:40 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 16, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169577
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
Line 260 (original), 260 (patched)


Good practice to always use braces.


- Alejandro Fernandez


On March 16, 2017, 10:40 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 16, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-16 Thread Anita Jebaraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/
---

Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
Ravindran.


Bugs: AMBARI-20334
https://issues.apache.org/jira/browse/AMBARI-20334


Repository: ambari


Description
---

capacity field in yarn queue manager should allow entering decimal numbers upto 
2 places,

currently the field allows entering values like

1.2.3
12...
1 2.3


Diffs
-

  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
 b6c419a 


Diff: https://reviews.apache.org/r/57709/diff/1/


Testing
---

Tested manually


Thanks,

Anita Jebaraj