Re: Review Request 57806: make home directory check as optional in hive20 view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169709 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 21, 2017, 2:10 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57806/ > --- > > (Updated March 21, 2017, 2:10 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20517 > https://issues.apache.org/jira/browse/AMBARI-20517 > > > Repository: ambari > > > Description > --- > > added property > views.skip.home-directory-check.file-system.list to skip home directory > checks in hive20 view > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/Constants.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java > 8adac24 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/ServiceCheck.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/SystemService.java > dd5bb06 > contrib/views/hive20/src/main/resources/ui/app/adapters/service-check.js > 22bf1b6 > > contrib/views/hive20/src/main/resources/ui/app/configs/service-check-status.js > 2810e80 > contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js > 10552ea > contrib/views/hive20/src/main/resources/ui/app/routes/service-check.js > 83111cd > contrib/views/hive20/src/main/resources/ui/app/services/service-check.js > a5a4755 > contrib/views/hive20/src/main/resources/ui/app/templates/service-check.hbs > 2a867aa > > > Diff: https://reviews.apache.org/r/57806/diff/1/ > > > Testing > --- > > tested cases where no property is present or no filesystem is present in the > property. > also tested cases where no service checks are done or odd number of service > checks are done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57806: make home directory check as optional in hive20 view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169694 --- Ship it! Ship It! - Pallav Kulshreshtha On March 21, 2017, 2:10 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57806/ > --- > > (Updated March 21, 2017, 2:10 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20517 > https://issues.apache.org/jira/browse/AMBARI-20517 > > > Repository: ambari > > > Description > --- > > added property > views.skip.home-directory-check.file-system.list to skip home directory > checks in hive20 view > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/Constants.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java > 8adac24 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/ServiceCheck.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/SystemService.java > dd5bb06 > contrib/views/hive20/src/main/resources/ui/app/adapters/service-check.js > 22bf1b6 > > contrib/views/hive20/src/main/resources/ui/app/configs/service-check-status.js > 2810e80 > contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js > 10552ea > contrib/views/hive20/src/main/resources/ui/app/routes/service-check.js > 83111cd > contrib/views/hive20/src/main/resources/ui/app/services/service-check.js > a5a4755 > contrib/views/hive20/src/main/resources/ui/app/templates/service-check.hbs > 2a867aa > > > Diff: https://reviews.apache.org/r/57806/diff/1/ > > > Testing > --- > > tested cases where no property is present or no filesystem is present in the > property. > also tested cases where no service checks are done or odd number of service > checks are done. > > > Thanks, > > Nitiraj Rathore > >