Re: Review Request 58615: Hive view 2.0 Error while uploading a table with partitioned columns

2017-04-25 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58615/#review172909
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 21, 2017, 12:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58615/
> ---
> 
> (Updated April 21, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20814
> https://issues.apache.org/jira/browse/AMBARI-20814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Partition information was handled in all queries except the insert from 
> query. 
> Done the required change to get the partition information from UI and using 
> it build 'insert from query'
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  8e22fc72b7 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java
>  4ff61b40a4 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 
> 42935fc573 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  5fee140bee 
> 
> 
> Diff: https://reviews.apache.org/r/58615/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 58615: Hive view 2.0 Error while uploading a table with partitioned columns

2017-04-21 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58615/#review172633
---


Ship it!




Ship It!

- Gaurav Nagar


On April 21, 2017, 12:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58615/
> ---
> 
> (Updated April 21, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20814
> https://issues.apache.org/jira/browse/AMBARI-20814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Partition information was handled in all queries except the insert from 
> query. 
> Done the required change to get the partition information from UI and using 
> it build 'insert from query'
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  8e22fc72b7 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java
>  4ff61b40a4 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 
> 42935fc573 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  5fee140bee 
> 
> 
> Diff: https://reviews.apache.org/r/58615/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>