Re: Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11

2017-05-17 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59222/#review175294
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 12, 2017, 5:15 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59222/
> ---
> 
> (Updated May 12, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-21001
> https://issues.apache.org/jira/browse/AMBARI-21001
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create a Hive 1.5.0 view instance and execute it in IE 11.
> 2. A blank page is displayed with the following error message in the web 
> console:
> SCRIPT1002: Syntax error
> File: hive.js, Line: 8374, Column: 23
> 
> The error is on this line in fetchServiceCheckPolicy in 
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
> 
> this.fetchServiceCheckPolicy()
> .then((data) => {
> 
> This is because the ES6 arrow (=>) functions are not supported in IE
> 
> 
> Diffs
> -
> 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js 
> 087bab3 
> 
> 
> Diff: https://reviews.apache.org/r/59222/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing in FF, Chrome and IE
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11

2017-05-17 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59222/#review175293
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 12, 2017, 5:15 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59222/
> ---
> 
> (Updated May 12, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-21001
> https://issues.apache.org/jira/browse/AMBARI-21001
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create a Hive 1.5.0 view instance and execute it in IE 11.
> 2. A blank page is displayed with the following error message in the web 
> console:
> SCRIPT1002: Syntax error
> File: hive.js, Line: 8374, Column: 23
> 
> The error is on this line in fetchServiceCheckPolicy in 
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
> 
> this.fetchServiceCheckPolicy()
> .then((data) => {
> 
> This is because the ES6 arrow (=>) functions are not supported in IE
> 
> 
> Diffs
> -
> 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js 
> 087bab3 
> 
> 
> Diff: https://reviews.apache.org/r/59222/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing in FF, Chrome and IE
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11

2017-05-11 Thread Sangeeta Ravindran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59222/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-21001
https://issues.apache.org/jira/browse/AMBARI-21001


Repository: ambari


Description
---

1. Create a Hive 1.5.0 view instance and execute it in IE 11.
2. A blank page is displayed with the following error message in the web 
console:
SCRIPT1002: Syntax error
File: hive.js, Line: 8374, Column: 23

The error is on this line in fetchServiceCheckPolicy in 
contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js

this.fetchServiceCheckPolicy()
.then((data) => {

This is because the ES6 arrow (=>) functions are not supported in IE


Diffs
-

  contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js 
087bab3 


Diff: https://reviews.apache.org/r/59222/diff/1/


Testing
---

Manual testing in FF, Chrome and IE


Thanks,

Sangeeta Ravindran