Re: Review Request 59741: File View : Download using Concatenate results in incorrect data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/#review176825 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 2, 2017, 6:25 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59741/ > --- > > (Updated June 2, 2017, 6:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21174 > https://issues.apache.org/jira/browse/AMBARI-21174 > > > Repository: ambari > > > Description > --- > > Earlier : incorrect copying of file input stream to output stream because of > which leftover bytes were getting written > In this patch: corrected the copying of stream using IOUtils > > > Diffs > - > > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 10b7c9edcc > > > Diff: https://reviews.apache.org/r/59741/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 59741: File View : Download using Concatenate results in incorrect data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/#review176799 --- Ship it! Ship It! - Alejandro Fernandez On June 2, 2017, 6:25 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59741/ > --- > > (Updated June 2, 2017, 6:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21174 > https://issues.apache.org/jira/browse/AMBARI-21174 > > > Repository: ambari > > > Description > --- > > Earlier : incorrect copying of file input stream to output stream because of > which leftover bytes were getting written > In this patch: corrected the copying of stream using IOUtils > > > Diffs > - > > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 10b7c9edcc > > > Diff: https://reviews.apache.org/r/59741/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 59741: File View : Download using Concatenate results in incorrect data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/#review176738 --- Ship it! Ship It! - Gaurav Nagar On June 2, 2017, 6:25 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59741/ > --- > > (Updated June 2, 2017, 6:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21174 > https://issues.apache.org/jira/browse/AMBARI-21174 > > > Repository: ambari > > > Description > --- > > Earlier : incorrect copying of file input stream to output stream because of > which leftover bytes were getting written > In this patch: corrected the copying of stream using IOUtils > > > Diffs > - > > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 10b7c9edcc > > > Diff: https://reviews.apache.org/r/59741/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Review Request 59741: File View : Download using Concatenate results in incorrect data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-21174 https://issues.apache.org/jira/browse/AMBARI-21174 Repository: ambari Description --- Earlier : incorrect copying of file input stream to output stream because of which leftover bytes were getting written In this patch: corrected the copying of stream using IOUtils Diffs - contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java 10b7c9edcc Diff: https://reviews.apache.org/r/59741/diff/1/ Testing --- Manual testing done. Thanks, Nitiraj Rathore
