Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/#review185358
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 13, 2017, 10:54 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62294/
> ---
> 
> (Updated Sept. 13, 2017, 10:54 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21944
> https://issues.apache.org/jira/browse/AMBARI-21944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Batch requests(Rolling Restart, HSI enable/disable, 
> decommission/recommission) not working when Ambari is configured with Knox 
> proxy
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
>  f3b3c415ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f901bda2b7 
>   ambari-web/app/controllers/main/host/details.js ad2ac98498 
>   ambari-web/app/controllers/main/service/item.js 224f83bdd9 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 140e7de641 
>   ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
>   
> ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
>  9a73a9a3e1 
> 
> 
> Diff: https://reviews.apache.org/r/62294/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster.
> verified that ambari-web unit test and ExecutionScheduleManagerTest test 
> passes successfully:
> 
>   30490 passing (20s)
>   157 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/
---

(Updated Sept. 13, 2017, 10:54 p.m.)


Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-21944
https://issues.apache.org/jira/browse/AMBARI-21944


Repository: ambari


Description
---

Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) 
not working when Ambari is configured with Knox proxy


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
 f3b3c415ee 
  
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
 f901bda2b7 
  ambari-web/app/controllers/main/host/details.js ad2ac98498 
  ambari-web/app/controllers/main/service/item.js 224f83bdd9 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
140e7de641 
  ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
  
ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
 9a73a9a3e1 


Diff: https://reviews.apache.org/r/62294/diff/2/

Changes: https://reviews.apache.org/r/62294/diff/1-2/


Testing
---

Tested manually on a cluster.
verified that ambari-web unit test and ExecutionScheduleManagerTest test passes 
successfully:

  30490 passing (20s)
  157 pending


Thanks,

Jaimin Jetly

Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/#review185336
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
Line 665 (original), 669 (patched)


If ambariWebResource is a class level reference why make it a param?



ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
Lines 803 (patched)


Why static?


- Sid Wagle


On Sept. 13, 2017, 8:25 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62294/
> ---
> 
> (Updated Sept. 13, 2017, 8:25 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21944
> https://issues.apache.org/jira/browse/AMBARI-21944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Batch requests(Rolling Restart, HSI enable/disable, 
> decommission/recommission) not working when Ambari is configured with Knox 
> proxy
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
>  f3b3c415ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f901bda2b7 
>   ambari-web/app/controllers/main/host/details.js ad2ac98498 
>   ambari-web/app/controllers/main/service/item.js 224f83bdd9 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 140e7de641 
>   ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
>   
> ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
>  9a73a9a3e1 
> 
> 
> Diff: https://reviews.apache.org/r/62294/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster.
> verified that ambari-web unit test and ExecutionScheduleManagerTest test 
> passes successfully:
> 
>   30490 passing (20s)
>   157 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy

2017-09-13 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/
---

Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-21944
https://issues.apache.org/jira/browse/AMBARI-21944


Repository: ambari


Description (updated)
---

Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) 
not working when Ambari is configured with Knox proxy


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
 f3b3c415ee 
  
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
 f901bda2b7 
  ambari-web/app/controllers/main/host/details.js ad2ac98498 
  ambari-web/app/controllers/main/service/item.js 224f83bdd9 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
140e7de641 
  ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 
  
ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
 9a73a9a3e1 


Diff: https://reviews.apache.org/r/62294/diff/1/


Testing (updated)
---

Tested manually on a cluster.
verified that ambari-web unit test and ExecutionScheduleManagerTest test passes 
successfully:

  30490 passing (20s)
  157 pending


Thanks,

Jaimin Jetly