Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193574 --- Ship it! Ship It! - Robert Nettleton On Dec. 12, 2017, 4:24 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64513/ > --- > > (Updated Dec. 12, 2017, 4:24 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. > > > Bugs: AMBARI-22630 > https://issues.apache.org/jira/browse/AMBARI-22630 > > > Repository: ambari > > > Description > --- > > set the storm config defaults for logseach as other teams needs it. > > this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can > be used in a hotfix > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml > d485017 > > > Diff: https://reviews.apache.org/r/64513/diff/3/ > > > Testing > --- > > not yet. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/ --- (Updated Dec. 12, 2017, 4:24 p.m.) Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. Changes --- upload the correct patch Bugs: AMBARI-22630 https://issues.apache.org/jira/browse/AMBARI-22630 Repository: ambari Description --- set the storm config defaults for logseach as other teams needs it. this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can be used in a hotfix Diffs (updated) - ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml d485017 Diff: https://reviews.apache.org/r/64513/diff/3/ Changes: https://reviews.apache.org/r/64513/diff/2-3/ Testing --- not yet. Thanks, Oliver Szabo
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193556 --- Last revision has noly whitespace changes? - Sid Wagle On Dec. 12, 2017, 4:19 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64513/ > --- > > (Updated Dec. 12, 2017, 4:19 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. > > > Bugs: AMBARI-22630 > https://issues.apache.org/jira/browse/AMBARI-22630 > > > Repository: ambari > > > Description > --- > > set the storm config defaults for logseach as other teams needs it. > > this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can > be used in a hotfix > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml > d485017 > > > Diff: https://reviews.apache.org/r/64513/diff/2/ > > > Testing > --- > > not yet. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/ --- (Updated Dec. 12, 2017, 4:19 p.m.) Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. Changes --- update with the commented block Bugs: AMBARI-22630 https://issues.apache.org/jira/browse/AMBARI-22630 Repository: ambari Description --- set the storm config defaults for logseach as other teams needs it. this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can be used in a hotfix Diffs (updated) - ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml d485017 Diff: https://reviews.apache.org/r/64513/diff/2/ Changes: https://reviews.apache.org/r/64513/diff/1-2/ Testing --- not yet. Thanks, Oliver Szabo
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193555 --- Ship it! Ship It! - Sid Wagle On Dec. 11, 2017, 11:47 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64513/ > --- > > (Updated Dec. 11, 2017, 11:47 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. > > > Bugs: AMBARI-22630 > https://issues.apache.org/jira/browse/AMBARI-22630 > > > Repository: ambari > > > Description > --- > > set the storm config defaults for logseach as other teams needs it. > > this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can > be used in a hotfix > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml > d485017 > > > Diff: https://reviews.apache.org/r/64513/diff/1/ > > > Testing > --- > > not yet. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193502 --- Ship it! Ship It! - Krisztian Kasa On Dec. 11, 2017, 11:47 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64513/ > --- > > (Updated Dec. 11, 2017, 11:47 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. > > > Bugs: AMBARI-22630 > https://issues.apache.org/jira/browse/AMBARI-22630 > > > Repository: ambari > > > Description > --- > > set the storm config defaults for logseach as other teams needs it. > > this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can > be used in a hotfix > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml > d485017 > > > Diff: https://reviews.apache.org/r/64513/diff/1/ > > > Testing > --- > > not yet. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193486 --- Ship it! Is it safe to put same configuration value from Storm logfeeder config? Then LGTM. - Jungtaek Lim On 12월 11, 2017, 11:47 오후, Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64513/ > --- > > (Updated 12월 11, 2017, 11:47 오후) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. > > > Bugs: AMBARI-22630 > https://issues.apache.org/jira/browse/AMBARI-22630 > > > Repository: ambari > > > Description > --- > > set the storm config defaults for logseach as other teams needs it. > > this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can > be used in a hotfix > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml > d485017 > > > Diff: https://reviews.apache.org/r/64513/diff/1/ > > > Testing > --- > > not yet. > > > Thanks, > > Oliver Szabo > >
Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/ --- Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. Bugs: AMBARI-22630 https://issues.apache.org/jira/browse/AMBARI-22630 Repository: ambari Description --- set the storm config defaults for logseach as other teams needs it. this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can be used in a hotfix Diffs - ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml d485017 Diff: https://reviews.apache.org/r/64513/diff/1/ Testing --- not yet. Thanks, Oliver Szabo
