Re: Review Request 64785: Disabled stack still appears in the UI if VDF is available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64785/#review194426 --- Ship it! Ship It! - Jonathan Hurley On Dec. 21, 2017, 4 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64785/ > --- > > (Updated Dec. 21, 2017, 4 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-22686 > https://issues.apache.org/jira/browse/AMBARI-22686 > > > Repository: ambari > > > Description > --- > > Ambari-2.6.1, Ambari UI still shows HDP-2.3 as a stack that is active > although the stack definition marks this as disabled. > > Seems like the UI does not make any calls to check stack active/in-active. > The stacks returned from VDF endpoint are then used to get the repo URLs > because the VDF returns the stack def as sub-resource which included the > in-active stack. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 4ac8574 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > e9567f1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 6bc8b95 > > > Diff: https://reviews.apache.org/r/64785/diff/1/ > > > Testing > --- > > Added a unit test. > Verified manually. > > > Thanks, > > Sid Wagle > >
Re: Review Request 64785: Disabled stack still appears in the UI if VDF is available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64785/#review194365 --- Ship it! Ship It! - Nate Cole On Dec. 21, 2017, 4 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64785/ > --- > > (Updated Dec. 21, 2017, 4 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-22686 > https://issues.apache.org/jira/browse/AMBARI-22686 > > > Repository: ambari > > > Description > --- > > Ambari-2.6.1, Ambari UI still shows HDP-2.3 as a stack that is active > although the stack definition marks this as disabled. > > Seems like the UI does not make any calls to check stack active/in-active. > The stacks returned from VDF endpoint are then used to get the repo URLs > because the VDF returns the stack def as sub-resource which included the > in-active stack. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 4ac8574 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > e9567f1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 6bc8b95 > > > Diff: https://reviews.apache.org/r/64785/diff/1/ > > > Testing > --- > > Added a unit test. > Verified manually. > > > Thanks, > > Sid Wagle > >
Review Request 64785: Disabled stack still appears in the UI if VDF is available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64785/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Nate Cole. Bugs: AMBARI-22686 https://issues.apache.org/jira/browse/AMBARI-22686 Repository: ambari Description --- Ambari-2.6.1, Ambari UI still shows HDP-2.3 as a stack that is active although the stack definition marks this as disabled. Seems like the UI does not make any calls to check stack active/in-active. The stacks returned from VDF endpoint are then used to get the repo URLs because the VDF returns the stack def as sub-resource which included the in-active stack. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4ac8574 ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java e9567f1 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 6bc8b95 Diff: https://reviews.apache.org/r/64785/diff/1/ Testing --- Added a unit test. Verified manually. Thanks, Sid Wagle
