Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82623 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83494 --- Ship it! Master (759ef68) is green with this patch.

Re: Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34121/#review83484 --- Ship it! Master (759ef68) is green with this patch.

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83487 --- Ship it!

Review Request 34124: Removing dead code from StateManagerImpl.

2015-05-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34124/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34121/#review83477 --- @ReviewBot retry - Maxim Khutornenko On May 12, 2015, 8:40 p.m.,

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- (Updated May 12, 2015, 9:17 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-12 Thread Bill Farner
On May 12, 2015, 8:09 p.m., Kevin Sweeney wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 265 https://reviews.apache.org/r/33612/diff/2/?file=950455#file950455line265 This seems unrelated to the description in this diff. It is related, as we don't have a

Re: Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34121/#review83481 --- What's the motivation here? Seems like attempted state transitions

Re: Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Maxim Khutornenko
On May 12, 2015, 9:22 p.m., Bill Farner wrote: What's the motivation here? Seems like attempted state transitions for unknown tasks should be transient and/or represent a bug. In those cases, i would assume we definitely want logging. Is there somthing i'm overlooking? The idea

Re: Review Request 34148: Enhancing the StateManager.changeState result.

2015-05-12 Thread Maxim Khutornenko
On May 13, 2015, 1:53 a.m., Aurora ReviewBot wrote: Master (bf7f9b7) is red with this patch. ./build-support/jenkins/build.sh :distZip :assemble :compileJmhJavaNote:

Re: Review Request 34124: Removing dead code from StateManagerImpl.

2015-05-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34124/#review83501 --- Ship it! Master (759ef68) is green with this patch.

Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34126/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Bill Farner
On May 12, 2015, 11:14 p.m., Aurora ReviewBot wrote: Master (c1b0dce) is red with this patch. ./build-support/jenkins/build.sh make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial' ../compiler/cpp/thrift --gen

Re: Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34126/#review83516 --- Ship it!

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689/ --- (Updated May 12, 2015, 10:56 p.m.) Review request for Aurora, Maxim

Re: Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Bill Farner
On May 12, 2015, 11:08 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-cluster.sh, line 33 https://reviews.apache.org/r/34126/diff/1/?file=957021#file957021line33 comment is a lie now, but it seems safe to remove as the update-alternatives line is self-explanatory

Re: Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34126/ --- (Updated May 12, 2015, 11:42 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34126/#review83513 --- Ship it! examples/vagrant/provision-dev-cluster.sh

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-12 Thread Ben Mahler
On May 12, 2015, 12:18 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 172 https://reviews.apache.org/r/33689/diff/4/?file=955534#file955534line172 The histogram would be interesting, but possibly overkill. We should be able to get