Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84794 --- Ship it! Master (998993d) is green with this patch.

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84798 --- Master (998993d) is green with this patch.

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84818 --- This patch does not apply cleanly on master (998993d), do you need

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84825 --- Master (998993d) is red with this patch.

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/ --- (Updated May 21, 2015, 4:28 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84821 --- Might be worth adding tests for the conditional startup of the

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84851 --- This change lgtm but I will need to ask you to do the following

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Kevin Sweeney
On May 21, 2015, 4:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding