Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/#review88804 --- Ship it! Ship It! - Maxim Khutornenko On June 19, 2015, 10:43

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-22 Thread Maxim Khutornenko
On June 19, 2015, 11:50 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java, line 127 https://reviews.apache.org/r/35672/diff/1/?file=988557#file988557line127 Curious, why special treating whitespacing here and not in other places? Bill

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88802 --- Ship it! Thanks!

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/ --- (Updated June 22, 2015, 4:51 p.m.) Review request for Aurora and Maxim

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88806 --- Ship it! Ship It! - Bill Farner On June 19, 2015, 10:07 p.m.,

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88850 --- Thanks for your contribution! Would you please add me to the people

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- (Updated June 22, 2015, 9:39 p.m.) Review request for Aurora. Repository:

Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- Review request for Aurora. Repository: aurora Description --- - Allow

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88857 --- Master (3351b09) is green with this patch.

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- (Updated June 22, 2015, 11:01 p.m.) Review request for Aurora and Zameer

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88863 --- Master (3351b09) is red with this patch.

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-22 Thread Kevin Sweeney
On June 4, 2015, 4:55 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/config/thrift.py, line 218 https://reviews.apache.org/r/34300/diff/3/?file=975774#file975774line218 Why set this at all? Does the scheduler read this field? Brian Wickman wrote: it is not. i will

Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1334