Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review101998 --- Ship it! Master (7408cb3) is green with this patch. ./build-supp

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Maxim Khutornenko
> On Oct. 9, 2015, 12:01 a.m., David McLaughlin wrote: > > This change is backwards incompatible. Shouldn't we add a new field that > > provides the new type and deprecate the old field as per the deprecation > > policy? > > Maxim Khutornenko wrote: > This API/struct were created for the U

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/ --- (Updated Oct. 9, 2015, 1:32 a.m.) Review request for Aurora, Joshua Cohen and B

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Joshua Cohen
> On Oct. 9, 2015, 12:01 a.m., David McLaughlin wrote: > > This change is backwards incompatible. Shouldn't we add a new field that > > provides the new type and deprecate the old field as per the deprecation > > policy? > > Maxim Khutornenko wrote: > This API/struct were created for the U

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Maxim Khutornenko
> On Oct. 9, 2015, 12:01 a.m., David McLaughlin wrote: > > This change is backwards incompatible. Shouldn't we add a new field that > > provides the new type and deprecate the old field as per the deprecation > > policy? This API/struct were created for the UI. Given that there are no other kn

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review101985 --- This change is backwards incompatible. Shouldn't we add a new field

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review101984 --- Ship it! Master (7408cb3) is green with this patch. ./build-supp

Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review101959 --- Ship it! Master (7408cb3) is green with this patch. ./build-supp

Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-1515