Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

2015-11-11 Thread Bill Farner
> On Nov. 10, 2015, 2:07 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, line 227 > > > > > > Is there a reason why we are not using Java's URI type to do this sort >

Re: Review Request 40149: Create ExecutorSettings closer to command line arguments.

2015-11-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40149/ --- (Updated Nov. 11, 2015, 8:16 a.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 40161: Clarify the commit process for new contributors.

2015-11-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40161/#review106081 --- Ship it! Ship It! - Bill Farner On Nov. 10, 2015, 3:40 p.m.,

Re: Review Request 40212: Trim whitespace for pants version

2015-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40212/#review106181 --- Ship it! Master (cf38611) is green with this patch.

Review Request 40204: Update pants bootstrap script to be agnostic to sed version

2015-11-11 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/ --- Review request for Aurora. Repository: aurora Description --- Update

Re: Review Request 40204: Update pants bootstrap script to be agnostic to sed version

2015-11-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/#review106171 --- Ship it! Ship It! - John Sirois On Nov. 11, 2015, 4:39 p.m.,

Re: Review Request 40204: Update pants bootstrap script to be agnostic to sed version

2015-11-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/#review106172 --- Ship it! Ship It! - Zameer Manji On Nov. 11, 2015, 3:39 p.m.,

Re: Review Request 40204: Update pants bootstrap script to be agnostic to sed version

2015-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/#review106173 --- Ship it! Master (0b025a7) is green with this patch.

Review Request 40208: Eliminate OOB pip install of python deps in CI.

2015-11-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40208/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-954

Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-547

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/#review106149 --- Ship it! Ship It! - Bill Farner On Nov. 11, 2015, 12:30 p.m.,

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/#review106147 --- Ship it! Master (0b025a7) is green with this patch.

Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/ --- Review request for Aurora, Kevin Sweeney, Brian Wickman, and Zameer Manji.

Re: Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/#review106164 --- Ship it! Master (0b025a7) is green with this patch.