Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131609 --- This patch does not apply cleanly against master (8a2fc4c), do you

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 1:45 a.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Joshua Cohen
> On May 3, 2016, 11 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 146 > > > > > > This can be removed, I guess. Yep, missed that, thanks. - Joshua

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Joshua Cohen
> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131602 --- Master (8a2fc4c) is red with this patch. ./build-support/jenkins

Re: Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131596 --- @ReviewBot retry - Maxim Khutornenko On May 3, 2016, 9:11 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131585 --- src/main/java/org/apache/aurora/scheduler/configuration/executor/

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131577 --- src/main/python/apache/aurora/config/schema/base.py (line 142)

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-05-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/ --- (Updated May 4, 2016, 12:24 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131573 --- Master (d8d1c8d) is red with this patch. ./build-support/jenkins

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 3, 2016, 10:04 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Joshua Cohen
> On May 3, 2016, 8:39 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 23 > > > > > > How would I do the mounting? Via the global container mounts scheduler > > option? > > > > So, once we have mounted t

Re: Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131561 --- Master (d8d1c8d) is red with this patch. ./build-support/jenkins

Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131547 --- RELEASE-NOTES.md (line 23)