Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 6, 2016, 8:22 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132097 --- Master (3687c6a) is red with this patch.

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 6, 2016, 7:41 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/ --- (Updated May 6, 2016, 6:32 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47076: Changing ResourceMapper interface arg type

2016-05-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47076/#review132091 --- Ship it! Ship It! - Zameer Manji On May 6, 2016, 11:10

Review Request 47076: Changing ResourceMapper interface arg type

2016-05-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47076/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132089 --- @ReviewBot retry - Joshua Cohen On May 6, 2016, 3:42 p.m.,

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-06 Thread Maxim Khutornenko
> On May 6, 2016, 11:31 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceBag.java, line > > 33 > > > > > > You define the `ResourceBag` as a bag of *unique* resource values.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132057 --- @ReviewBot retry - Joshua Cohen On May 6, 2016, 3:42 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132056 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132052 --- Ship it! Ship It! - Stephan Erb On May 6, 2016, 5:42 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 6, 2016, 3:42 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132040 --- docs/reference/configuration.md (line 606)

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132043 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132039 --- @ReviewBot retry - Joshua Cohen On May 6, 2016, 2:23 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132035 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Joshua Cohen
> On May 6, 2016, 11:03 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 32 > > > > > > Isn't that a "removal" and should thus fit into the previous section? > > > > If you want to make it more prominent

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 6, 2016, 2:23 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/#review132010 ---

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132006 --- LGTM! A couple of minor things below. RELEASE-NOTES.md (line