Re: Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/#review136562 --- Ship it! Master (583607a) is green with this patch. ./build-s

Re: Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/ --- (Updated June 7, 2016, 11:26 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/ --- (Updated June 7, 2016, 11:18 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Renan DelValle
> On June 7, 2016, 9:41 p.m., Joshua Cohen wrote: > > docs/operations/configuration.md, lines 154-162 > > > > > > Rather than explaining this in conversational English, it might be > > easier to understand if we jus

Re: Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/#review136552 --- Thanks for adding this, great to get it documented! Would you min

Re: Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/#review136553 --- Ship it! Master (692074c) is green with this patch. ./build-s

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review136549 --- Master (692074c) is red with this patch. ./build-support/jenkins

Re: Review Request 48359: Adding gpg key for serb

2016-06-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48359/#review136548 --- Ship it! Master (692074c) is green with this patch. ./build-s

Re: Review Request 48359: Adding gpg key for serb

2016-06-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48359/#review136547 --- Ship it! Ship It! - Maxim Khutornenko On June 7, 2016, 9:19

Re: Review Request 48359: Adding gpg key for serb

2016-06-07 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48359/ --- (Updated June 7, 2016, 11:19 p.m.) Review request for Aurora. Changes ---

Re: Review Request 48359: Adding gpg key for serb

2016-06-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48359/#review136537 --- KEYS (line 461)

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 7, 2016, 9:01 p.m.) Review request for Aurora, Joshua Cohen and S

Review Request 48360: Updated documentation to include custom executor explaination

2016-06-07 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-07 Thread Maxim Khutornenko
> On June 7, 2016, 6:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/Utilization.java, lines > > 127-137 > > > > > > Feel free to punt on this, but maybe extract a private method that

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 7, 2016, 8:58 p.m.) Review request for Aurora, Joshua Cohen and S

Review Request 48359: Adding gpg key for serb

2016-06-07 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48359/ --- Review request for Aurora. Repository: aurora Description --- Adding gpg

Re: Review Request 48082: AURORA-1624 New thrift API for retrieving tier configuration

2016-06-07 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/ --- (Updated June 7, 2016, 8:40 p.m.) Review request for Aurora, Joshua Cohen and M

Re: Review Request 48082: AURORA-1624 New thrift API for retrieving tier configuration

2016-06-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136530 --- Ship it! Ship It! - Maxim Khutornenko On June 7, 2016, 8:17

Re: Review Request 48082: AURORA-1624 New thrift API for retrieving tier configuration

2016-06-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136527 --- Master (e667493) is red with this patch. ./build-support/jenkins

Re: Review Request 48082: AURORA-1624 New thrift API for retrieving tier configuration

2016-06-07 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/ --- (Updated June 7, 2016, 8:17 p.m.) Review request for Aurora, Joshua Cohen and M

Re: Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-07 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48218/ --- (Updated June 7, 2016, 8:41 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-07 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136509 --- Fix it, then Ship it! api/src/main/thrift/org/apache/aurora/ge

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review136514 --- Ship it! Feel free to ignore both comments below ;). src/main

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136486 --- Just a few minor changes left! RELEASE-NOTES.md (line 43)