Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-27 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/ --- (Updated June 27, 2016, 6:18 p.m.) Review request for Aurora. Changes

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-27 Thread Renan DelValle
> On June 24, 2016, 4:33 p.m., David McLaughlin wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 266-267 > > > > > > Please rename to something like mesosFetcherUris (or just fetcherUris) > >

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-27 Thread Renan DelValle
> On June 27, 2016, 9:44 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 145 > > > > > > typo Fixed thanks! > On June 27, 2016, 9:44 a.m., Maxim Khutornenko wrote: >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
> On June 27, 2016, 11:31 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 129-130 > > > > > > Can you simplify this as: > > ``` > > return not

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Maxim Khutornenko
> On June 27, 2016, 6:31 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 129-130 > > > > > > Can you simplify this as: > > ``` > > return not

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
> On June 27, 2016, 11:31 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/config.py, line 118 > > > > > > Please, add a link to our docs for more info: > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
> On June 27, 2016, 11:31 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 129-130 > > > > > > Can you simplify this as: > > ``` > > return not

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139597 --- src/main/python/apache/aurora/client/api/__init__.py (line 298)

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139598 --- Ship it! Master (73dd2a8) is green with this patch.

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/#review139588 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 145)

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139589 --- Master (73dd2a8) is red with this patch.