Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review145455 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 11, 2016, 1:32

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review145453 --- Ship it! Master (9084664) is green with this patch. ./build-s

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Igor Morozov
> On Aug. 10, 2016, 5:14 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, > > lines 131-133 > > > > > > This needs to be updated to include ROLL_FORWARD

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated Aug. 11, 2016, 1:32 a.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50902/#review145393 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 8, 2016, 5:13

Re: Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-10 Thread Mehrdad Nurolahzade
> On Aug. 10, 2016, 10:36 a.m., Maxim Khutornenko wrote: > > The easiest way to validate doc changes like this is to push your branch to > > your github remote and post a link here for review. Care to give it a try? > > Mehrdad Nurolahzade wrote: > Will do. Here is the github fork: https:/

Re: Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-10 Thread Mehrdad Nurolahzade
> On Aug. 10, 2016, 10:36 a.m., Maxim Khutornenko wrote: > > The easiest way to validate doc changes like this is to push your branch to > > your github remote and post a link here for review. Care to give it a try? Will do. - Mehrdad

Re: Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50902/#review145364 --- The easiest way to validate doc changes like this is to push your

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review145356 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateContro