Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147781 --- Ship it! Ship It! - Stephan Erb On Sept. 5, 2016, 8:56

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Kai Huang
> On Sept. 3, 2016, 10:14 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java, line 76 > > > > > > Please update the documentation to cover the new SLA metric > >

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review14 --- Ship it! Master (5d3f945) is green with this patch.

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- (Updated Sept. 5, 2016, 6:56 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-05 Thread Kai Huang
> On Sept. 1, 2016, 7:53 p.m., Zameer Manji wrote: > > Can you set the depends on field of this review to be `51536`? So we know > > that this patch is blocked on that review landing first? > > Stephan Erb wrote: > Is it really blocked? Nothing would be wrong or broken if we submit this >