Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150972 --- Ship it! Master (655105d) is green with this patch. ./build-s

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150970 --- Ship it! Master (655105d) is green with this patch. ./build-s

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-29 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- (Updated Sept. 29, 2016, 11:43 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-29 Thread Kai Huang
> On Sept. 28, 2016, 9:52 p.m., Joshua Cohen wrote: > > I tried to commit this, but e2e tests hung for me. > > > > Kai, can you investigate? > > Kai Huang wrote: > There is a bug of thermos kill for task running in docker > container(https://issues.apache.org/jira/browse/AURORA-1426 ). It

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-29 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/ --- (Updated Sept. 29, 2016, 11:11 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150942 --- one data valiadation issue, everything else LGTM. src/main/pytho

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-29 Thread Kai Huang
> On Sept. 28, 2016, 9:52 p.m., Joshua Cohen wrote: > > I tried to commit this, but e2e tests hung for me. > > > > Kai, can you investigate? There is a bug of thermos kill for task running in docker container(https://issues.apache.org/jira/browse/AURORA-1426 ). It is likely due to my code cha

Re: Review Request 52367: Upgrade to latest pants 1.2.0 pre-release.

2016-09-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52367/#review150882 --- Ship it! Ship It! - Joshua Cohen On Sept. 28, 2016, 10:51 p.

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52300/#review150864 --- lgtm overall. Just two small changes and it's gtg... src/main/py