Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53114/#review153768 --- Ship it! Master (7ac639b) is green with this patch.

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-10-24 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53114/ --- (Updated Oct. 25, 2016, 2:14 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-10-24 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53114/ --- (Updated Oct. 25, 2016, 2:06 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-10-24 Thread Jing Chen
> On Oct. 24, 2016, 4:04 p.m., Joshua Cohen wrote: > > Thanks once again for the patch! > > > > If I'm missing something and the changes on the non-json rendering side are > > necessary, can you also ensure that the output there is identical > > before/after your patch (i.e. run `aurora job

Re: Review Request 53102: Clean up README for packaging repo, update release-candidate script to generate the vote email.

2016-10-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53102/#review153730 --- Ship it! Ship It! - John Sirois On Oct. 22, 2016, 11:46

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-10-24 Thread Jing Chen
> On Oct. 24, 2016, 4:04 p.m., Joshua Cohen wrote: > > Thanks once again for the patch! > > > > If I'm missing something and the changes on the non-json rendering side are > > necessary, can you also ensure that the output there is identical > > before/after your patch (i.e. run `aurora job

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-10-24 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53114/#review153696 --- Thanks once again for the patch! If I'm missing something and

Re: Review Request 53131: Re-introduce --executor_registration_timeout.

2016-10-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53131/#review153695 --- Ship it! Ship It! - Stephan Erb On Oct. 24, 2016, 2:39

Re: Review Request 53131: Re-introduce --executor_registration_timeout.

2016-10-24 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53131/#review153689 --- Ship it! Ship It! - Joshua Cohen On Oct. 24, 2016, 12:39

Re: Review Request 53131: Re-introduce --executor_registration_timeout.

2016-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53131/#review153683 --- Ship it! Master (e1cde4f) is green with this patch.

Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.

2016-10-24 Thread John Sirois
> On Oct. 23, 2016, 12:12 p.m., John Sirois wrote: > > Sorry for the delay submitting this, e2e didn't actually pass and I futzed > > with this for a while. > > At the end of the day I needed to re-introduce > > `examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout` > >

Review Request 53131: Re-introduce --executor_registration_timeout.

2016-10-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53131/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: aurora