Re: Review Request 53519: Tear down the observer in case of on unhandled errors

2016-11-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53519/#review156802 --- Ship it! Ship It! - John Sirois On Nov. 23, 2016, 3:25 p.m.,

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-11-23 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Nov. 23, 2016, 3:03 p.m.) Review request for Aurora, Dmitriy Shirchenk

Re: Review Request 53519: Tear down the observer in case of on unhandled errors

2016-11-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53519/#review156795 --- Ship it! LGTM. I like this approach and I think we could also u

Re: Review Request 53519: Tear down the observer in case of on unhandled errors

2016-11-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53519/#review156794 --- Master (b099e2f) is green with this patch. ./build-support/jenki

Re: Review Request 53519: Tear down the observer in case of on unhandled errors

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53519/ --- (Updated Nov. 23, 2016, 11:25 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 53519: WIP: ExceptionalThread that will tear down the entire application on unhandled errors

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53519/ --- (Updated Nov. 23, 2016, 11:24 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156791 --- Ship it! Ship It! - Joshua Cohen On Nov. 23, 2016, 7:44 p.m.

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156775 --- Ship it! Master (4797dfe) is green with this patch. ./build-s

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/ --- (Updated Nov. 23, 2016, 11:44 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156761 --- Fix it, then Ship it! src/jmh/java/org/apache/aurora/benchmark

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Zameer Manji
> On Nov. 23, 2016, 4:36 a.m., Stephan Erb wrote: > > Have you considerd writing a single benchmark with a single `run()` method > > that: > > > > * inserts pending tasks > > * assigns the pending tasks > > * deletes the tasks > > > > Even though the benchmark would not be very fine grained, I

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review156728 --- Ship it! Looks good to me! @jcohen, what do you think? Sorry a

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156727 --- Have you considerd writing a single benchmark with a single `run()

Re: Review Request 53923: Filter out calls to fromResource for resources that Aurora does not support yet to avoid crashing

2016-11-23 Thread Stephan Erb
> On Nov. 19, 2016, 11:12 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java, > > line 204 > > > > > > Use `SUPPORTED_RESOURCE` here as well. > > Renan DelValle wr