Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

2016-12-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158815 --- Master (c8e8953) is red with this patch.

Re: Review Request 54624: Expose stats on ZooKeeper connection state

2016-12-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54624/#review158814 --- Master (c8e8953) is green with this patch.

Re: Review Request 54624: Expose stats on ZooKeeper connection state

2016-12-11 Thread Jing Chen
> On Dec. 10, 2016, 8:14 p.m., Joshua Cohen wrote: > > I think the idea behind the ticket was to track these as stats, not just > > into the log. btw, I am not pretty sure if `AtomicLong`s here should be `static` or not - Jing ---

Re: Review Request 54624: Expose stats on ZooKeeper connection state

2016-12-11 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54624/ --- (Updated Dec. 12, 2016, 1:32 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

2016-12-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158812 --- @ReviewBot retry - Zameer Manji On Dec. 11, 2016, 4:43 p.m.,