Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/ --- Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs:

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159929 --- Master (38b9311) is green with this patch.

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/ --- (Updated Dec. 21, 2016, 10:49 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

> On Dec. 21, 2016, 6:26 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java, > > lines 97-98 > > > > > > Inline? This was originally inline but threw PMD

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159911 --- Is it even worth making this a controllable option? I think it's

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159914 ---

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

> On Dec. 22, 2016, 1:23 a.m., Mehrdad Nurolahzade wrote: > > Could you please refactor away from `Stats`, as was suggested by @zmanji on > > a similar rb [https://reviews.apache.org/r/54959/]? @Mehrdad will do. - Pradyumna --- This

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159903 --- Master (38b9311) is green with this patch.

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review159902 --- Could you please refactor away from `Stats`, as was suggested by

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review159900 --- Master (38b9311) is green with this patch.

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/ --- (Updated Dec. 21, 2016, 5:11 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

> On Dec. 21, 2016, 4:33 p.m., Aurora ReviewBot wrote: > > Master (38b9311) is red with this patch. > > ./build-support/jenkins/build.sh > > > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > >

Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/ --- Review request for Aurora and Mehrdad Nurolahzade. Repository: aurora

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

> On Dec. 22, 2016, 12:54 a.m., Karthik Anantha Padmanabhan wrote: > > src/main/python/apache/aurora/admin/aurora_admin.py, line 55 > > > > > > In the current implementation we retry only when a `TimeoutError` is >

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159896 --- src/main/python/apache/aurora/admin/aurora_admin.py (line 55)

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159891 --- src/main/python/apache/aurora/admin/aurora_admin.py (line 51)

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159894 --- Master (38b9311) is red with this patch.

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159893 --- Ship it! LGTM modulo my `Stats` vs `StatsProvider` comment.

Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1842

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159890 --- Ship it! Master (38b9311) is green with this patch.