Re: Review Request 56062: Fix flapping TestRunnerKillProcessGroup test

2017-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56062/#review163564 --- Ship it! Ship It! - Zameer Manji On Jan. 29, 2017, 9:53

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163562 --- Ship it! Ship It! - David McLaughlin On Jan. 30, 2017,

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163551 --- This is on master now. - Zameer Manji On Jan. 30, 2017, 10:23

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163550 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2017, 10:23

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163541 --- Ship it! Master (7be7ad6) is green with this patch.

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-30 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/ --- (Updated Jan. 30, 2017, 6:23 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163518 --- Ship it! - Pradyumna Kaushik On Jan. 30, 2017, 12:55 p.m.,

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread Pradyumna Kaushik
> On Jan. 30, 2017, 2:32 p.m., Pradyumna Kaushik wrote: > > Ship it! - Pradyumna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163518

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163509 --- Ship it! Master (7be7ad6) is green with this patch.

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163504 --- @ReviewBot retry - Stephan Erb On Jan. 30, 2017, 1:55 p.m.,

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163502 --- Master (7be7ad6) is red with this patch.

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-30 Thread Stephan Erb
> On Jan. 28, 2017, 12:37 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java, > > lines 65-72 > > > > > > Can `invocation.proceed();` ever return

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

2017-01-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/ --- (Updated Jan. 30, 2017, 1:55 p.m.) Review request for Aurora, Pradyumna