Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

2017-02-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review166465 --- Ship it! Ship It! - David McLaughlin On Jan. 28, 2017, 9:15

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166455 --- Ship it! Master (98eb99a) is green with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-22 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166450 --- @ReviewBot retry - Dmitriy Shirchenko On Feb. 22, 2017, 10:35

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

2017-02-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review166430 --- This is only a very partial review. My brain was not capable of

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166435 --- Master (98eb99a) is red with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-22 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166434 --- @ReviewBot retry - Dmitriy Shirchenko On Feb. 22, 2017, 10:35

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166432 --- This patch does not apply cleanly against RB#56690 (98eb99a), do

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

2017-02-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review166427 --- Ship it! LGTM. - Stephan Erb On Jan. 28, 2017, 10:15 p.m.,

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/ --- (Updated Feb. 22, 2017, 11:34 a.m.) Review request for Aurora, David

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
> On Feb. 22, 2017, 10:27 a.m., Zameer Manji wrote: > > Could you please add to the RB description on what methodology you used to > > determine this and what are the results of this patch? > > > > > > Further, do you have any ideas on how we can prevent regressions? Short-term, we need to

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
> On Feb. 22, 2017, 10:07 a.m., Reza Motamedi wrote: > > Mehrdad, do you also have some stats on how much these changes reduced the > > object creation rate? The object allocation rate dropped from of 25 M/s on average to 15-20 M/s. But, as I indicated above these numbers are not

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review166385 --- Mehrdad, do you also have some stats on how much these changes

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

2017-02-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/#review166376 ---