Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

2017-03-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57433/#review168360 --- Master (a07b9ed) is green with this patch. ./build-support/jenki

Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

2017-03-08 Thread Mehrdad Nurolahzade
> On March 8, 2017, 1:32 p.m., Zameer Manji wrote: > > I don't like how we are porting features to a module that should die, but I > > see no harm in this. Hopefully this would be only an interim change while we are testing curator implementation. - Mehrdad

Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

2017-03-08 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57433/ --- (Updated March 8, 2017, 1:55 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

2017-03-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57433/#review168346 --- Master (a07b9ed) is green with this patch. ./build-support/jenki

Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

2017-03-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57433/#review168338 --- Ship it! I don't like how we are porting features to a module t

Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

2017-03-08 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57433/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-1895

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

2017-03-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168332 --- Master (932e908) is green with this patch. ./build-support/jenki

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

2017-03-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168331 --- @ReviewBot retry - Zameer Manji On March 7, 2017, 6:05 p.m., Za

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

2017-03-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168329 --- Ship it! Ship It! - Stephan Erb On März 8, 2017, 3:05 vorm.,

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

2017-03-08 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168323 --- Ship it! Ship It! - David McLaughlin On March 8, 2017, 2:05