Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
/ Changes: https://reviews.apache.org/r/54957/diff/4-5/ Testing --- * Manual testing * ./build-support/jenkins/build.sh passes Thanks, Karthik Anantha Padmanabhan

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
ed? duh ! Bad push my bad. - Karthik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169894 --- On March 23, 2017, 4:23

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
://reviews.apache.org/r/54957/diff/4/ Changes: https://reviews.apache.org/r/54957/diff/3-4/ Testing --- * Manual testing * ./build-support/jenkins/build.sh passes Thanks, Karthik Anantha Padmanabhan

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef Diff: https://reviews.apache.org/r/54957/diff/3/ Testing (updated) --- * Manual testing * ./build-support/jenkins/build.sh passes Thanks, Karthik Anantha Padmanabhan

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef Diff: https://reviews.apache.org/r/54957/diff/3/ Changes: https://reviews.apache.org/r/54957/diff/2-3/ Testing --- * Manuall testing * ./build-support/jenkins/build.sh passes Thanks, Karthik Anantha Padmanabhan

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef Diff: https://reviews.apache.org/r/54957/diff/2/ Changes: https://reviews.apache.org/r/54957/diff/1-2/ Testing --- * Manuall testing * ./build-support/jenkins/build.sh passes Thanks, Karthik Anantha Padmanabhan

Re: Review Request 55237: WIP for idempotent api endpoints.

2017-01-10 Thread Karthik Anantha Padmanabhan
f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef src/test/python/apache/aurora/common/test_transport.py c3d35d278a68db603954ad1e3cf26c6359ae3926 Diff: https://reviews.apache.org/r/55237/diff/ Testing --- Works locally. Not good for a review , this is just work in progress. Thanks, Karthik Anantha Padmanabhan

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-01-05 Thread Karthik Anantha Padmanabhan
> On Jan. 4, 2017, 11:54 p.m., Karthik Anantha Padmanabhan wrote: > > I was going to wrap this up - but how do people feel about making the all > > endpoints "idempotent" by the following method ? Inlcude an > > "idempotency-token" along as part

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Karthik Anantha Padmanabhan
> On Dec. 22, 2016, 12:54 a.m., Karthik Anantha Padmanabhan wrote: > > src/main/python/apache/aurora/admin/aurora_admin.py, line 55 > > <https://reviews.apache.org/r/54957/diff/1/?file=1590757#file1590757line55> > > > > In the current implementation we

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Karthik Anantha Padmanabhan
esolve the leader url etc. - Karthik Anantha Padmanabhan On Dec. 22, 2016, 12:06 a.m., Karthik Anantha Padmanabhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

2016-12-02 Thread Karthik Anantha Padmanabhan
> On Dec. 2, 2016, 10:37 p.m., Zameer Manji wrote: > > Can someone else validate that the tests pass for them locally? I can't > > reproduce the jenkins failure. I wonder if this is a timing issue in the tests ? `expectGroupEvent(PathChildrenCacheEvent.Type.CHILD_ADDED)` returns as soon as

Review Request 51900: Add reconciliation_explicit_batch_size scheduler option to the documentation

2016-09-14 Thread Karthik Anantha Padmanabhan
31be71491de00e53ce4764e480ff2728d06a3f1d Diff: https://reviews.apache.org/r/51900/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-12 Thread Karthik Anantha Padmanabhan
Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-12 Thread Karthik Anantha Padmanabhan
afac2500551af2fce406bb906aa4e33f353e90a1 Diff: https://reviews.apache.org/r/51662/diff/ Testing --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Karthik Anantha Padmanabhan
afac2500551af2fce406bb906aa4e33f353e90a1 Diff: https://reviews.apache.org/r/51662/diff/ Testing --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Karthik Anantha Padmanabhan
Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-08 Thread Karthik Anantha Padmanabhan
.apache.org/r/51662/#review148230 --- On Sept. 8, 2016, 5:27 p.m., Karthik Anantha Padmanabhan wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-08 Thread Karthik Anantha Padmanabhan
generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148225 --------------- On Sept. 8, 2016, 5:27 p.m., Karthik Anantha Padmanabhan wrote: > > --- > Thi

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-08 Thread Karthik Anantha Padmanabhan
eviews.apache.org/r/51662/#review148128 --- On Sept. 8, 2016, 6:48 a.m., Karthik Anantha Padmanabhan wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-08 Thread Karthik Anantha Padmanabhan
/python/apache/aurora/client/api/test_scheduler_client.py afac2500551af2fce406bb906aa4e33f353e90a1 Diff: https://reviews.apache.org/r/51662/diff/ Testing --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
/client/api/test_scheduler_client.py afac2500551af2fce406bb906aa4e33f353e90a1 Diff: https://reviews.apache.org/r/51662/diff/ Testing --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
ning the "explicit" and "implicit" reconciliation > > RPCs into a single "reconcile" RPC with an optional batchSize argument, so > > that it maps to the mesos master API. > > > > http://mesos.apache.org/documentation/latest/reconciliation/ >

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
ning the "explicit" and "implicit" reconciliation > > RPCs into a single "reconcile" RPC with an optional batchSize argument, so > > that it maps to the mesos master API. > > > > http://mesos.apache.org/documentation/latest/reconciliation/ >

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
ttps://reviews.apache.org/r/51662/#review148089 --- On Sept. 7, 2016, 9:08 p.m., Karthik Anantha Padmanabhan wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
/ Testing --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
Diff: https://reviews.apache.org/r/51662/diff/ Testing --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Karthik Anantha Padmanabhan
ik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148046 --- On Sept. 6, 2016, 11:34 p.m., Karthik Anantha Padmanabhan wrote: >

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review147953 --- @ReviewBot retry - Karthik Anantha Padmanabhan On Sept. 6

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
/client/api/test_scheduler_client.py afac2500551af2fce406bb906aa4e33f353e90a1 Diff: https://reviews.apache.org/r/51662/diff/ Testing (updated) --- * Manually tested on my local vagrant installation * ./build-support/jenkins/build.sh Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
/test_scheduler_client.py afac2500551af2fce406bb906aa4e33f353e90a1 Diff: https://reviews.apache.org/r/51662/diff/ Testing --- * Manually tested on my local vagrant installation Thanks, Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 779dc302602ae8842084807ca868a491ea99b676 Diff: https://reviews.apache.org/r/51662/diff/ Testing (updated) --- * Manually tested on my local vagrant installation Thanks, Karthik Anantha Padmanabhan

Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
/SchedulerThriftInterfaceTest.java 779dc302602ae8842084807ca868a491ea99b676 Diff: https://reviews.apache.org/r/51662/diff/ Testing --- Thanks, Karthik Anantha Padmanabhan