Review Request 42979: Enable ping query to prevent use of invalid pooled connections.

://reviews.apache.org/r/42979/diff/ Testing --- Thanks, Zameer Manji

Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

/42985/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

` to let operators take advantage of this flag. src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java (line 45) <https://reviews.apache.org/r/42964/#comment178076> Since this is a custom header perhaps we should prefix it with `X-`? - Zameer Manji On Jan. 29, 2016,

Re: Review Request 42922: Revert "Improving job update query performance."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42922/#review116827 --- Ship it! Ship It! - Zameer Manji On Jan. 28, 2016, 2:15 p.m

Re: Review Request 42896: Remove timestamp from task IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42896/#review116798 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2016, 8:53 p.m

Re: Review Request 42882: Improving job update query performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42882/#review116678 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2016, 4:25 p.m

Re: Review Request 42845: Enable H2 logging to slf4j.

ine32> > > > > I believe you can omit this line, as it will inherit the root logger's > > appenders. Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 42845: Enable H2 logging to slf4j.

/42845/diff/ Testing --- Set the level to debug initially and observed extra output in Vagrant. Thanks, Zameer Manji

Re: Review Request 42869: Fix stray printf style log replacement token when logging triggered cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42869/#review116632 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2016, 1:16 p.m

Review Request 42845: Enable H2 logging to slf4j.

output in Vagrant. Thanks, Zameer Manji

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116397 --- Ship it! Ship It! - Zameer Manji On Jan. 26, 2016, 7 a.m

Re: Review Request 42727: Remove the --announcer-enable executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116398 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2016, 10:03

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > <https://reviews.apache.org/r/42565/diff/3/?file=1203749#file1203749line80> > > > > Just

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115903 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2016, 10:47 a.m

Re: Review Request 42668: Remove most direct uses of deprecated TaskConfig fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42668/#review115954 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2016, 11:23

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review115663 --- On Jan. 20, 2016, 2:39 p.m., Zameer Manji wrote: > &

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

hy BlockingQueue and not something like ConcurrentLinkedQueue? There > > is nothing to block here for. > > Zameer Manji wrote: > `BlockingQueue` has the `drainTo` method which I think makes the > iteration nicer. > > Maxim Khutornenko wrote: > The price for that is exce

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

295960f13693c6ba0d7075a8ef7f9680a91ae69d Diff: https://reviews.apache.org/r/42332/diff/ Testing --- ./gradlew build -Pq e2e tests Thanks, Zameer Manji

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

eply, visit: https://reviews.apache.org/r/42332/#review115730 ------- On Jan. 21, 2016, 2:55 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42332/ &g

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

/TaskHistoryPrunerTest.java 295960f13693c6ba0d7075a8ef7f9680a91ae69d Diff: https://reviews.apache.org/r/42332/diff/ Testing --- ./gradlew build -Pq e2e tests Thanks, Zameer Manji

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115705 --- Ship it! Ship It! - Zameer Manji On Jan. 21, 2016, 12:40 p.m

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

295960f13693c6ba0d7075a8ef7f9680a91ae69d Diff: https://reviews.apache.org/r/42332/diff/ Testing --- ./gradlew build -Pq e2e tests Thanks, Zameer Manji

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

for errors so a > > higher limit should suffice (e.g. 5 seconds). No, it does not have to run every second. Changed it to every 5 seconds. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

/TaskHistoryPruner.java (line 146) <https://reviews.apache.org/r/42639/#comment176831> Is it safe to call this method from multiple threads? Nothing in the Guava documentation indicates this is the case. - Zameer Manji On Jan. 21, 2016, 6:47 p.m., John Sirois

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115782 --- Ship it! Ship It! - Zameer Manji On Jan. 21, 2016, 6:47 p.m

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

6 is submitting a task with a delay so I don't think this is possible. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review115517 ------- On Jan. 20, 2016, 2:39 p.m., Zameer Manji wrote: > > -

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

Diff: https://reviews.apache.org/r/42332/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

295960f13693c6ba0d7075a8ef7f9680a91ae69d Diff: https://reviews.apache.org/r/42332/diff/ Testing --- ./gradlew build -Pq e2e tests Thanks, Zameer Manji

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

75 --- On Jan. 19, 2016, 9:49 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41804/ > ------- > > (Updated Jan.

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

some of the code by using `default` methods. - Zameer Manji On Jan. 19, 2016, 9:49 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

---- On Jan. 14, 2016, 3:58 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42328/ > ---

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

s (updated) - src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 5facc048bc21adb124cb761647553afa9f8ab724 Diff: https://reviews.apache.org/r/42328/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 42332: Trigger shutdown on task pruning failure.

iews.apache.org/r/42332/#review114732 --- On Jan. 14, 2016, 4:53 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 42332: Trigger shutdown on task pruning failure.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114795 ------- On Jan. 14, 2016, 4:53 p.m., Zameer Manji wrote: > >

Review Request 42332: Trigger shutdown on task pruning failure.

295960f13693c6ba0d7075a8ef7f9680a91ae69d Diff: https://reviews.apache.org/r/42332/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Review Request 42328: Add metric for counting uncaught exceptions in async executor.

che/aurora/scheduler/base/AsyncUtil.java 5facc048bc21adb124cb761647553afa9f8ab724 Diff: https://reviews.apache.org/r/42328/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

s (updated) - NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 5facc048bc21adb124cb761647553afa9f8ab724 Diff: https://reviews.apache.org/r/42328/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114580 --- Ship it! Ship It! - Zameer Manji On Jan. 14, 2016, 1:10 p.m

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

- > > (Updated Jan. 14, 2016, 1:10 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. > > > Bugs: AURORA-1576 > https://issues.apache.org/jira/browse/AURORA-1576 > > > Repository: aurora > > > Descr

Review Request 42225: Add `--show-error` to curl when bootstrapping thrift.

ile 8b1da2a01b9ecc1832d4e56bfaacb5b40cdbbab0 Diff: https://reviews.apache.org/r/42225/diff/ Testing --- Ran `make` in the `build-support/thrift` directory. Thanks, Zameer Manji

Re: Review Request 42145: Use tags instead of branches for release candidates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42145/#review113809 --- Ship it! Ship It! - Zameer Manji On Jan. 11, 2016, 7:22 a.m

Re: Review Request 42117: Change release script to use rel/ tag prefix.

releases? - Zameer Manji On Jan. 10, 2016, 10:26 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 42078: Bump JMH to 1.11.2.

/42078/diff/ Testing --- ./gradlew jmh -Pbenchmarks='UpdateStoreBenchmarks.*' Thanks, Zameer Manji

Re: Review Request 42080: Upgrade to pants 0.0.67.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42080/#review113520 --- Ship it! Ship It! - Zameer Manji On Jan. 8, 2016, 11:39 a.m

Re: Review Request 42041: Enable H2 query statistics collection.

ions from having it ON by default? Should it > > be a configurable flag instead? > > Zameer Manji wrote: > Good question, I'll run benchmarks and update the testing done. > > John Sirois wrote: > And if there are perf implications, there is always [`SET > QUERY_STATIS

Re: Review Request 42041: Enable H2 query statistics collection.

SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 18429.830 ± 3077.426 ops/s Thanks, Zameer Manji

Re: Review Request 42041: Enable H2 query statistics collection.

ions from having it ON by default? Should it > > be a configurable flag instead? > > Zameer Manji wrote: > Good question, I'll run benchmarks and update the testing done. > > John Sirois wrote: > And if there are perf implications, there is always [`SET > QUERY_STATIS

Re: Review Request 42041: Enable H2 query statistics collection.

eviews.apache.org/r/42041/#review113355 ------- On Jan. 7, 2016, 3:14 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 42034: Adding gpg key for jsir...@apache.org.

/aurora` directories on the dist svn. - Zameer Manji On Jan. 7, 2016, 12:39 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

arguments to a module under an interface/POJO that can be injected is good organization. I think we can go forward with steps #1 and #2 (in two different reviews) immediately and start a discussion for #3 should be like on the dev@ list. - Zameer Manji On Dec. 30, 2015, 4:03 p.m., Bill Farner

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

ttps://reviews.apache.org/r/41804/ > --- > > (Updated Dec. 30, 2015, 4:03 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This begins to define a proposed r

Re: Review Request 41785: Remove scheduler log scaffolding

by default? I think that is more valuable when debugging issues and will reudce the size of each log line. - Zameer Manji On Jan. 3, 2016, 9:04 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 41777: Use slf4j throughout the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/#review112479 --- Ship it! - Zameer Manji On Dec. 29, 2015, 4:06 p.m., Bill

Re: Review Request 41786: Remove several scheduler command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41786/#review112362 --- Ship it! Ship It! - Zameer Manji On Dec. 29, 2015, 5:52 p.m

Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.

as it improves our testing. src/main/java/org/apache/aurora/scheduler/thrift/Thresholds.java (line 19) <https://reviews.apache.org/r/41711/#comment172293> Please add a `toString` method to this class. - Zameer Manji On Dec. 24, 2015, 2:43 p.m., Bill Farner

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

was the suggested work around on my post on the gradle forum. - Zameer Manji On Dec. 28, 2015, 3:15 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41537: Upgrade mesos dependency to 0.25.0

> On Dec. 26, 2015, 4:45 p.m., Stephan Erb wrote: > > Exception message: Could not satisfy all requirements for > > mesos.native==0.25.0: > > mesos.native==0.25.0 > > > > The end-to-end tests are failing to me. Is that local issue or do we need > > to upload that egg somewhere? > >

Re: Review Request 41591: Remove the deprecated ConfigGroup.instanceIds field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41591/#review111538 --- Ship it! Ship It! - Zameer Manji On Dec. 20, 2015, 9:25 a.m

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

. Please swap me out for Joshua. - Zameer Manji On Dec. 15, 2015, 11:15 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41368: Remove the client-side updater.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110719 --- Ship it! Awesome! - Zameer Manji On Dec. 14, 2015, 2:36 p.m

Re: Review Request 41413: Add PMD coverage for test sources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41413/#review110579 --- Ship it! Ship It! - Zameer Manji On Dec. 15, 2015, 3:31 p.m

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

/browse/AURORA-1543 and assigning the ticket to yourself? - Zameer Manji On Dec. 12, 2015, 8:49 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41154: Add support for performing health checks with a shell command.

I'm good as well. - Zameer Manji On Dec. 10, 2015, 11:25 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41331: Upgrade to pants 0.0.64 and pex 1.1.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41331/#review110284 --- Ship it! Ship It! - Zameer Manji On Dec. 13, 2015, 3:32 p.m

Re: Review Request 41154: Add support for performing health checks with a shell command.

date the documentation of `expected_response_code` to be "If not zero, fail the HTTP health check..." src/main/python/apache/aurora/client/config.py (line 163) <https://reviews.apache.org/r/41154/#comment169740> You need to call `_validate_health_check_config` here. - Zame

Re: Review Request 41154: Add support for performing health checks with a shell command.

umentation can then be updated to explain which fields are expected for each type. I think this might make it easier to add more types of health checking in the future. - Zameer Manji On Dec. 10, 2015, 1:16 p.m., Dmitriy Shirchenko wrote: > >

Re: Review Request 41074: Use lambdas throughout the project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41074/#review109356 --- Ship it! Ship It! - Zameer Manji On Dec. 8, 2015, 10:01 a.m

Re: Review Request 40786: Replace manual Forwarding* with `@Forward`.

and it does remove boilerplate code. - Zameer Manji On Nov. 30, 2015, 7:05 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40786: Replace manual Forwarding* with `@Forward`.

. John, can you please rebase this? - Zameer Manji On Nov. 30, 2015, 7:05 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

> On Dec. 2, 2015, 4:36 p.m., Maxim Khutornenko wrote: > > 3rdparty/python/BUILD, line 14 > > > > > > Am I reading this as revving up mesos native version in Aurora? If so, > > we should also update build.gradle and

Re: Review Request 41056: Upgrade checkstyle and pmd versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41056/#review109215 --- Ship it! Ship It! - Zameer Manji On Dec. 7, 2015, 2:56 p.m

Review Request 40673: Set JDK and langauge level for entire project.

1.8 with JDK 8 langauge features. Thanks, Zameer Manji

Re: Review Request 40656: Remove SessionKey from APIs and implementations.

communicate against this scheduler. - Zameer Manji On Nov. 24, 2015, 12:29 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 40689: Upgrade RBTools to 0.7.5

and ran ./rbt Thanks, Zameer Manji

Re: Review Request 40662: Remove jersey dependency from commons code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40662/#review107815 --- Ship it! Ship It! - Zameer Manji On Nov. 24, 2015, 10:41 a.m

Re: Review Request 40658: Copy artifacts from containers rather than using volume mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40658/#review107821 --- Ship it! Ship It! - Zameer Manji On Nov. 24, 2015, 9:24 a.m

Re: Review Request 40656: Remove SessionKey from APIs and implementations.

later remove it from the client side if you don't want to tackle that now. - Zameer Manji On Nov. 24, 2015, 9:19 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 40666: Remove unnecessary volume mount argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40666/#review107827 --- Ship it! Ship It! - Zameer Manji On Nov. 24, 2015, 11:36 a.m

Review Request 40510: Remove unused and deprecated code from commons.

/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f Diff: https://reviews.apache.org/r/40510/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 40510: Remove unused and deprecated code from commons.

/scheduler/log/mesos/MesosLogStreamModule.java 377dbfda85a1e1e47e3855b9dcdf538ffb843e54 Diff: https://reviews.apache.org/r/40510/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 40510: Remove unused and deprecated code from commons.

377dbfda85a1e1e47e3855b9dcdf538ffb843e54 Diff: https://reviews.apache.org/r/40510/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40391/#review106946 --- Ship it! Ship It! - Zameer Manji On Nov. 17, 2015, 9:51 a.m

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106712 --- Ship it! Ship It! - Zameer Manji On Nov. 15, 2015, 3:36 p.m

Re: Review Request 40320: Organize executor-related code into a package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40320/#review106709 --- Ship it! Ship It! - Zameer Manji On Nov. 14, 2015, 9 a.m

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

org/r/40310/#comment165447> Out of curiosity, could we replace isort with this functionality? I like the idea of collapsing all of that functionality into pants. - Zameer Manji On Nov. 16, 2015, 9:30 a.m., John Sirois

Re: Review Request 40201: Cleanup thermos_executor test pexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/#review106467 --- Ship it! Ship It! - Zameer Manji On Nov. 13, 2015, 7:32 a.m

Re: Review Request 40304: Upgrade to checkstyle 6.12.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40304/#review106507 --- Ship it! Ship It! - Zameer Manji On Nov. 13, 2015, 10:39 a.m

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

> On Nov. 12, 2015, 11:05 a.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a cu

Re: Review Request 40208: Eliminate OOB pip install of python deps in CI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40208/#review106297 --- Ship it! Ship It! - Zameer Manji On Nov. 11, 2015, 3:58 p.m

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

custom pants plugin is the way to go here. Historically we have been very bad at upgrading pants and maintaining it, I'm afraid that if we add a custom plugin here we won't be able to upgrade pants in the future at all. - Zameer Manji On Nov. 12, 2015, 12:54 a.m., John Sirois wrote

Re: Review Request 40204: Update pants bootstrap script to be agnostic to sed version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/#review106172 --- Ship it! Ship It! - Zameer Manji On Nov. 11, 2015, 3:39 p.m

Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105990 --- Ship it! Thanks John! - Zameer Manji On Nov. 10, 2015, 2:58

Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.

a ship because as it stands it will break the release scripts we have. - Zameer Manji On Nov. 10, 2015, 1:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

/SchedulerMain.java (line 227) <https://reviews.apache.org/r/40149/#comment164662> Is there a reason why we are not using Java's URI type to do this sort of parsing? - Zameer Manji On Nov. 10, 2015, 12:42 p.m., Bill Farner

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39958/#review105716 --- Ship it! Ship It! - Zameer Manji On Nov. 4, 2015, 5:26 p.m

Re: Review Request 40043: Adding GPG key for zma...@apache.org.

/aurora/KEYS Diffs - KEYS dff0fb48f1b0e8a18bc21014cc425d7d48f08c6d Diff: https://reviews.apache.org/r/40043/diff/ Testing --- None. Please verify my key is correct. Thanks, Zameer Manji

Re: Review Request 39822: upgrade psutil to 3.2.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39822/#review104787 --- Ship it! Ship It! - Zameer Manji On Oct. 30, 2015, 1:14 p.m

Re: Review Request 39822: upgrade psutil to 3.2.2

triy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39822/ > --- > > (Updated Oct. 30, 2015, 1:14 p.m.) > > > Review request for

Re: Review Request 39822: upgrade psutil to 3.2.2

and highlight any API changes we might need to be aware of? - Zameer Manji On Oct. 30, 2015, 11:17 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java a1ac922d471013779710e02c0c9ca9f84b506807 Diff: https://reviews.apache.org/r/39670/diff/ Testing --- ./gradlew build -Pq If the approach is good, I can update this with benchmark information. Thanks, Zameer Manji

<    1   2   3   4   5   6   7   8   >