---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/
---
(Updated May 13, 2015, 11:32 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/
---
(Updated May 12, 2015, 10:56 p.m.)
Review request for Aurora, Maxim
On May 12, 2015, 12:18 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 172
https://reviews.apache.org/r/33689/diff/4/?file=955534#file955534line172
The histogram would be interesting, but possibly overkill. We should
be able to get
On May 7, 2015, 10:24 p.m., Maxim Khutornenko wrote:
src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line
191
https://reviews.apache.org/r/33689/diff/3/?file=951768#file951768line191
Delete TODO.
Zameer Manji wrote:
+1
Done.
On May 7, 2015, 10:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review83268
---
Ship it!
Master (aabb692) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/
---
(Updated May 11, 2015, 6:55 p.m.)
Review request for Aurora, Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review83293
---
Ship it!
On May 11, 2015, 10:02 p.m., Maxim Khutornenko wrote:
Thanks! Bill is taking a look as well, so I will wait for his feedback before
updating.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review83304
---
Ship it!
Overall LGTM. I'd like to see the move away from the
On May 10, 2015, 12:10 p.m., Stephan Erb wrote:
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 211
https://reviews.apache.org/r/33689/diff/3/?file=951771#file951771line211
You mentioned that updates should be processed in FIFO order. As we
have effectively
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review83184
---
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review82916
---
Looks good overall. A few suggestions below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review82774
---
Master (fef7194) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/
---
(Updated May 6, 2015, 11:34 p.m.)
Review request for Aurora, Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review82780
---
Ship it!
Master (fef7194) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/
---
(Updated May 7, 2015, 12:27 a.m.)
Review request for Aurora, Maxim Khutornenko
On May 4, 2015, 9:56 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, lines
199-203
https://reviews.apache.org/r/33689/diff/1/?file=947578#file947578line199
This isn't necessary. You can use `.execute(...)` instead and rely on a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review82433
---
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33689/#review82343
---
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java
19 matches
Mail list logo
