Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132089 --- @ReviewBot retry - Joshua Cohen On May 6, 2016, 3:42 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132057 --- @ReviewBot retry - Joshua Cohen On May 6, 2016, 3:42 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132056 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132052 --- Ship it! Ship It! - Stephan Erb On May 6, 2016, 5:42 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 6, 2016, 3:42 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132040 --- docs/reference/configuration.md (line 606)

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132043 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132039 --- @ReviewBot retry - Joshua Cohen On May 6, 2016, 2:23 p.m.,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132035 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 6, 2016, 11:03 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 32 > > > > > > Isn't that a "removal" and should thus fit into the previous section? > > > > If you want to make it more prominent

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 6, 2016, 2:23 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132006 --- LGTM! A couple of minor things below. RELEASE-NOTES.md (line

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 6:41 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 4, 2016, 4:47 p.m., Maxim Khutornenko wrote: > > build-support/packer/build.sh, line 68 > > > > > > Is it possible to carve out a version constant here? Sure, will do. - Joshua

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131710 --- Ship it! Master (8a2fc4c) is green with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131707 --- @ReviewBot retry - Maxim Khutornenko On May 4, 2016, 2:36

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131703 --- Ship it! build-support/packer/build.sh (line 68)

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131685 --- Ship it! Master (8a2fc4c) is green with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 2:36 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131679 --- Master (8a2fc4c) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 2:13 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131609 --- This patch does not apply cleanly against master (8a2fc4c), do

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 1:45 a.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 3, 2016, 11 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 146 > > > > > > This can be removed, I guess. Yep, missed that, thanks. - Joshua

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131585 ---

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131577 --- src/main/python/apache/aurora/config/schema/base.py (line 142)

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131573 --- Master (d8d1c8d) is red with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 3, 2016, 10:04 p.m.) Review request for Aurora, John Sirois,

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 3, 2016, 8:39 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 23 > > > > > > How would I do the mounting? Via the global container mounts scheduler > > option? > > > > So, once we have mounted

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131547 --- RELEASE-NOTES.md (line 23)

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 2, 2016, 2:54 p.m., John Sirois wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 172 > > > > > > The MesosJob is trending more and more towards a c-style union, > > different parts of

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 2, 2016, 8:54 a.m., John Sirois wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 172 > > > > > > The MesosJob is trending more and more towards a c-style union, > > different parts of

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On May 2, 2016, 2:54 p.m., John Sirois wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 172 > > > > > > The MesosJob is trending more and more towards a c-style union, > > different parts of

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131153 --- I've hung back from a detailed review base on Maxim's comment.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

> On April 29, 2016, 11:39 p.m., Maxim Khutornenko wrote: > > Following up on our offline conversation, it would be great to explore the > > feasibility of running executor outside of user image. This was one of the > > proposed [goals](http://markmail.org/message/g2xkh7nzzblokdgk) behind > >

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131220 --- Following up on our offline conversation, it would be great to

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131130 --- Ship it! Master (450d881) is green with this patch.